Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[milvus] Add podLabels option for attu. #1

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[milvus] Add podLabels option for attu. #1

merged 1 commit into from
Aug 16, 2023

Conversation

brandonschabell
Copy link
Contributor

What this PR does / why we need it:

This adds pod labels to pods created as part of the attu deployment.

Checklist

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@brandonschabell
Add podLabels option for attu.
02a9c3c 
Signed-off-by: Brandon Schabell <[email protected]>
@brandonschabell brandonschabell mentioned this pull request Aug 16, 2023
Closed
3 tasks
@brandonschabell
Copy link
Contributor Author

@LoveEachDay Here's the new PR.

LoveEachDay
LoveEachDay approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@LoveEachDay LoveEachDay merged commit b85412b into zilliztech:master Aug 16, 2023
1 check passed
@brandonschabell brandonschabell deleted the attu-pod-labels branch August 16, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

Assignees
No one assigned
Labels
approved ci-passed lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonschabell @LoveEachDay