-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add namespace metadata #72
Conversation
Signed-off-by: mchtech <[email protected]>
Signed-off-by: mchtech <[email protected]>
Welcome @mchtech! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
Hi @mchtech, sry for the delay. Please also bump the version before we could merge it. |
branch synced. |
@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, mchtech The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
branch synced. |
/lgtm |
What this PR does / why we need it:
metadata.namespace
is missing in some templates.this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)