Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹🥔✨ Utilities: Tidy up #edit and #destroy use-cases #1328

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Apr 8, 2023

I noticed my local Space had two Stripe utilities and I wanted to get rid of one but I couldn't because the feature didn't exist.

So now it does.

I also ditched the Utility form from the Space#edit page and made the list of utilities look more like the list of furniture, with edit and trash buttons on the right.

After

Screenshot 2023-04-08 at 4 25 15 PM

Screenshot 2023-04-08 at 4 25 06 PM

Screenshot 2023-04-08 at 4 24 54 PM

Before

Screenshot 2023-04-08 at 4 26 29 PM

Screenshot 2023-04-08 at 4 26 18 PM

@zspencer zspencer requested review from anaulin, KellyAH and a team April 8, 2023 23:23
@zspencer zspencer changed the title Utilities: Tidy up #edit and #destroy use-cases 🧹✨ Utilities: Tidy up #edit and #destroy use-cases Apr 8, 2023
- #252

I noticed my local Space had two `Stripe` utilities and I wanted to get
rid of one but I couldn't because the feature didn't exist.

So now it does.

I also ditched the `Utility` form from the `Space#edit` page and made
the list of utilities look more like the list of furniture, with edit
and trash buttons on the right.
@zspencer zspencer force-pushed the utilities/member-destroys-utility branch from a6dd8bd to 6cd74d2 Compare April 8, 2023 23:28
@zspencer zspencer changed the title 🧹✨ Utilities: Tidy up #edit and #destroy use-cases 🧹🥔✨ Utilities: Tidy up #edit and #destroy use-cases Apr 8, 2023
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🧹 refactor Includes non-behavioral changes 🥔 Satisfices It's good enough to use, but not particularly great labels Apr 8, 2023
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay CRUD operations! 🎉

@zspencer zspencer merged commit 928cd7c into main Apr 9, 2023
@zspencer zspencer deleted the utilities/member-destroys-utility branch April 9, 2023 04:46
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🧹 refactor Includes non-behavioral changes 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants