🐞🔨 Journal: Show error messages when Entry cannot be saved
#1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://github.com/zinc-collective/convene/issues/1566 Womp womp; apparently I had forgotten to do the `unprocessable_entity`, which meant that `turbo` was failing miserably instead of replacing the form when creating or updating a journal entry. Well; now it's fixed!
anaulin
reviewed
Jul 5, 2023
| @@ -9,6 +9,7 @@ class Entry < ApplicationRecord | |||
| scope :recent, -> { order("published_at DESC NULLS FIRST") } | |||
|
|
|||
| attribute :headline, :string | |||
| validates :headline, presence: true | |||
There was a problem hiding this comment.
Not really part of your PR, but now that we have the strip_attributes gem, it might be worth throwing that on for headline and body, just so that we don't store trailing/preceding whitespace.
There was a problem hiding this comment.
Yah! I was thinking about that then I forgot 🤦
zspencer
deleted the
journal/correctly-handle-unprocessable-journal-entries
branch
zspencer
added a commit
that referenced
this pull request
Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566 - #1630 (comment) > Not really part of your PR, but now that we have the > `strip_attributes` gem, it might be worth throwing that on for > `headline` and `body`, just so that we don't store trailing/preceding > whitespace.
zspencer
added a commit
that referenced
this pull request
Jul 6, 2023
- https://github.com/zinc-collective/convene/issues/1566 - #1630 (comment) > Not really part of your PR, but now that we have the > `strip_attributes` gem, it might be worth throwing that on for > `headline` and `body`, just so that we don't store trailing/preceding > whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal: WritingEntriesjournal#2Womp womp; apparently I had forgotten to do the
unprocessable_entity, which meant thatturbowas failing miserably instead of replacing the form when creating or updating a journal entry.Well; now it's fixed!