🐞🔨 Journal: Entry supports overlapping Keywords
#1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1714 Turns out, it was a renderer-layer thing; where the shorter `Keyword` was getting linkfied prior to the longer `Keyword`, and when I switched to linkify the longer `Keyword` first it would double-down on the links putting a link to the shorter keyword within the longer one! So now I'm matching the `#` as part of the `Keyword`, and replacing it with the html entity for `#`, (aka `#`) This makes it so when we linkify keywords long-to-short; the longer keywords no longer contain the shorter keyword; eliminating the nested `a` tags.
zspencer
changed the title
Journal: Entry body supports multiple overlapping KeywordsJournal: Entry supports overlapping Keywords
I noticed I had dropped the `reverse` in the `keywords_regex` method, and thought... "hmm, that may not be a great thing..." So I went to write some test cases that would force the reverse to be put back in; which meant I needed a keyword with aliases...
zspencer
force-pushed
the
journal/long-keywords-dont-get-ignored-when-linkifying
branch
from
bda0a88 to
245a2da
Compare
zspencer
deleted the
journal/long-keywords-dont-get-ignored-when-linkifying
branch
|
I want my bug fixxxeeeeed so I am merging without review. YOLO! Still curious about any questions that come-up from review by @zinc-collective/convene-contributors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal:Entrywith overlappingKeywordsignore the longerKeyword#1714Turns out, it was a renderer-layer thing; where the shorter
Keywordwas getting linkfied prior to the longerKeyword, and when I switched to linkify the longerKeywordfirst it would double-down on the links putting a link to the shorter keyword within the longer one!So now I'm matching the
#as part of theKeyword, and replacing it with the html entity for#, (aka#)This makes it so when we linkify keywords long-to-short; the longer keywords no longer contain the shorter keyword; eliminating the nested
atags.