Initial implementation of Utilities #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user512
approved these changes
May 7, 2021
| def self.append_routes(routing_context) | ||
| REGISTRY.values.each do |furniture| | ||
| REGISTRY.each_value do |furniture| |
There was a problem hiding this comment.
Rubocop made me do it! But I liked it!
zspencer
force-pushed
the
186/sprout-plaid-utility
branch
from
83a6fc7 to
6ba6e16
Compare
anaulin
reviewed
May 8, 2021
convene-web/app/models/space.rb
Outdated
| Utilities.from_utility_hookup(jitsi_hookup).meet_domain | ||
| end | ||
|
|
||
| def hookups |
There was a problem hiding this comment.
Is this used anywhere? I couldn't find a usage example in this PR (but its big, so likely I missed it?). Looking at the implementation, it reads like it returns Utilities, not UtilityHookups, so I was trying to understand how it is used.
There was a problem hiding this comment.
Probably not! Thank you!
anaulin
approved these changes
May 8, 2021
Utilities connect a Space to an external vendor or service provider, such as a Jitsi Meet or BigBlueButton deployment for video; or Stripe or Paypal for payments; or AirTable or Google Sheets for a "database" - Sketching out how to move Jitsi to a Hookup
It just felt tooooo weird saying "Hookup" all the time.
zspencer
force-pushed
the
186/sprout-plaid-utility
branch
from
9f1e681 to
7a805e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #252