Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

WIP: scaffold for public schedule link. #39

Draft
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

cjoulain
Copy link
Contributor

@cjoulain cjoulain commented Jun 2, 2020

We're setting up public schedules for each team member using this route format:

  • /team_members/:team_member_public_schedule_slug/schedules

Copy link
Member

@zspencer zspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Is there an issue this is connected to? Do you have a plan-of-action for next steps?

I tend to take little notes in my pull-requests with prompts like:

  • Figure out what the page should even look like
  • Ask @zspencer or @maximegalon5 what other use cases we intend to support for public scheduling, as well as what other products we have that want a scheduling feature
  • Write a feature test
  • ???

@@ -3,6 +3,9 @@

resources :inboxes, only: [:show]
resources :inbound_messages, only: [:create, :show]
resources :team_members, param: :public_schedule_slug do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by this name, is it the public_schedule_slug or is it the team_member_slug

I.e. is this going to be used to look up the team member or the schedule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that a nested resource is unnecessary here, as we may want to have a schedule that has many team members

@zspencer
Copy link
Member

@cjoulain - Hey CJ! Was wondering if there's anything I can do to bring this in to land?

@cjoulain
Copy link
Contributor Author

Apologies for the delay, @zspencer. Had prioritized feature tests on another project but can start to work on Support again the week of July 20.

In terms of what this draft tried to address, I think it was this (#25) issue.

And that this was the scenario and step we had wanted to build out:

Scenario: Malicious Actor Invites Team Member's Public Schedule Availability Email Address to an Event
 
Given a Team Member with a Public Schedule Link

We saw that there was a TeamMember class and the seed file had one public slug called zee. It looked like the schedule logic needed to be built out so that would render on the UI and we could start to test for security.

Screen Shot 2020-07-11 at 1 32 58 PM

Referencing the points Zee had raised above:

Figure out what the page should even look like

This is a good prompt. What fields should be displayed on a team_member schedule page?

Ask @zspencer or @maximegalon5 what other use cases we intend to support for public scheduling, as well as what other products we have that want a scheduling feature

Zee and @maximegalon5: do other Zinc products already have a scheduling feature that we can use as a model or template?

Also CC-ing @user512 who is really knowledgable about building backend logic and had paired with me on the draft. Tom: let me know if I'm misunderstanding or if there's anything I left out.

@maximegalon5
Copy link
Contributor

@cjoulain to the best of my knowledge we don't have a prior to model on.

@zspencer
Copy link
Member

I think I would do some research into other scheduling landing pages.

For example:

Calendly: https://calendly.com/zee
When2Meet: https://www.when2meet.com/
HubSpot: https://www.hubspot.com/products/sales/schedule-meeting
Google Appointment Slots: https://wp.nyu.edu/digitalgallatin/portfolio/how-to-create-appointment-slots/

Etc. to get an idea for what layout may make sense. Then I'd recommend sketching out something roughly (paper is fine, or using a tool of your choice).

I'm also happy to do a rough sketch for how I imagine it looking/working.

Re: Other products - We are considering adding a scheduling feature into Convene so that people can use it to figure out when to meet with their internal team-mates but I don't know if it's worth conflating the design of that with this until we know more about what that would look like and work like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants