-
Notifications
You must be signed in to change notification settings - Fork 5
WIP: scaffold for public schedule link. #39
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Is there an issue this is connected to? Do you have a plan-of-action for next steps?
I tend to take little notes in my pull-requests with prompts like:
- Figure out what the page should even look like
- Ask @zspencer or @maximegalon5 what other use cases we intend to support for public scheduling, as well as what other products we have that want a scheduling feature
- Write a feature test
- ???
@@ -3,6 +3,9 @@ | |||
|
|||
resources :inboxes, only: [:show] | |||
resources :inbound_messages, only: [:create, :show] | |||
resources :team_members, param: :public_schedule_slug do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by this name, is it the public_schedule_slug
or is it the team_member_slug
I.e. is this going to be used to look up the team member or the schedule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be that a nested resource is unnecessary here, as we may want to have a schedule that has many team members
@cjoulain - Hey CJ! Was wondering if there's anything I can do to bring this in to land? |
Apologies for the delay, @zspencer. Had prioritized feature tests on another project but can start to work on Support again the week of July 20. In terms of what this draft tried to address, I think it was this (#25) issue. And that this was the scenario and step we had wanted to build out:
We saw that there was a TeamMember class and the seed file had one public slug called Referencing the points Zee had raised above:
This is a good prompt. What fields should be displayed on a team_member schedule page?
Zee and @maximegalon5: do other Zinc products already have a scheduling feature that we can use as a model or template? Also CC-ing @user512 who is really knowledgable about building backend logic and had paired with me on the draft. Tom: let me know if I'm misunderstanding or if there's anything I left out. |
@cjoulain to the best of my knowledge we don't have a prior to model on. |
I think I would do some research into other scheduling landing pages. For example: Calendly: https://calendly.com/zee Etc. to get an idea for what layout may make sense. Then I'd recommend sketching out something roughly (paper is fine, or using a tool of your choice). I'm also happy to do a rough sketch for how I imagine it looking/working. Re: Other products - We are considering adding a scheduling feature into Convene so that people can use it to figure out when to meet with their internal team-mates but I don't know if it's worth conflating the design of that with this until we know more about what that would look like and work like. |
We're setting up public schedules for each team member using this route format: