Skip to content

Commit

Permalink
HACKING: Update status of format checking
Browse files Browse the repository at this point in the history
Hopefully all functions with printf like arguments now use format checking.

This was tested with default build configuration on linux
and windows hosts (including some cross compilations),
so chances are good that there remain few (if any) functions
without format checking.

Therefore the last comment in HACKING is no longer valid but misleading.

Cc: Blue Swirl <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
  • Loading branch information
Stefan Weil authored and Anthony Liguori committed Feb 25, 2011
1 parent c53af37 commit 417131f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions HACKING
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.

Currently many functions in QEMU are not following this rule but
patches to add the attribute would be very much appreciated.

0 comments on commit 417131f

Please sign in to comment.