Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stream to be interrupted when there is no traffic #1251

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Allow stream to be interrupted when there is no traffic #1251

merged 2 commits into from
Jun 10, 2024

Commits on Jun 7, 2024

  1. Allow stream to be interrupted when there is no traffic 

    When a partition is lost while there is no traffic, `PartitionStreamControl` is blocked waiting for data. We fix this by racing with the `interruptPromise`. (Thanks @josdirksen for the analysis!)

Note: this situation can only occur with lost partitions. Timeouts (the other reason for interrupts) do not occur when there is no traffic. Currently, we have no way to test lost partitions. Therefore, there are no added tests.

See #1250.
    @erikvanoosten
    erikvanoosten committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1b16bbd View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. More type safety

    @erikvanoosten
    erikvanoosten committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    1a8a9fc View commit details
    Browse the repository at this point in the history