Remove lost partitions from assigned streams #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvanoosten
approved these changes
Oct 29, 2024
|
Let's ship this asap! 😄 |
zio-kafka-test/src/test/scala/zio/kafka/consumer/internal/RunloopSpec.scala
Outdated
Show resolved
Hide resolved
erikvanoosten
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288. See also #1233 and #1250.
When all partitions are lost after some connection issue to the broker, the streams for lost partitions are ended but polling stops, due to the conditions in
Runloop.State#shouldPoll. This PR fixes this by removing the lost partition streams from theassignedStreamsin the state, thereby not disabling polling.Also adds a warning that is logged whenever the assigned partitions (according to the apache kafka consumer) are different from the assigned streams, which helps to identify other issues or any future regressions of this issue.
Still needs a good test, theMockConsumerused in other tests unfortunately does not allow simulating lost partitions, and the exact behavior of the kafka client in this situation is hard to predict..Includes a test that fails when undoing the change to Runloop