More specific errors than Throwable for Consumer #1361
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly replaces Throwable with
ConsumerError
, a hierarchy of custom types we can later extend, and a fallbackUnknownConsumerException
. Some exceptions that can be thrown from the underlyingKafkaConsumer
which would indicate programming errors in zio-kafka are translated to fiber deaths (as per ZIO recommendations).At some places we have more specific errors.
PartitionStreamPullTimeout
orDeserializationError
.CommitError
, which is aCommitTimeout
orUnknownCommitException
.I hope in the future these sub-hierarchies don't cause any conflicts.
Build still fails because test and bench projects have not been migrated yet, first want to gather some feedback on this change.
Implements #241