Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max.poll.records i.s.o. config name #1381

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

erikvanoosten
Copy link
Collaborator

@erikvanoosten erikvanoosten commented Nov 13, 2024

This is for readability, there are no behavior changes. The benchmarks continue to use 1000 as value of the max.poll.records config.

Copy link
Collaborator

@svroonland svroonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not have a functional effect due to order of assigning the properties, but is clearer

@erikvanoosten erikvanoosten merged commit e1a4144 into master Nov 13, 2024
6 of 9 checks passed
@erikvanoosten erikvanoosten deleted the bench-equalizer branch November 13, 2024 09:27
@erikvanoosten erikvanoosten changed the title Use same max.poll.records in all benchmarks Use max.poll.records i.s.o. config name Nov 13, 2024
@erikvanoosten
Copy link
Collaborator Author

Should not have a functional effect due to order of assigning the properties, but is clearer

Updated title and description to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants