Add pretty errors #226
Merged
Add pretty errors #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnspade
force-pushed
the
pretty-errors
branch
from
88ac7d3
to
562d60a
Compare
johnspade
commented
Mar 30, 2024
| val positions = lines.scanLeft(0)(_ + _.length + 1) // +1 for newline character | ||
| val errorLineIndex = positions.indexWhere(_ > pos) - 1 | ||
|
|
||
| val contextRange = (math.max(errorLineIndex - 2, 0), math.min(errorLineIndex + 2, lines.length - 1)) |
There was a problem hiding this comment.
For multiline input, output the previous two lines and the next two lines, replace the rest with an ellipsis
| @@ -1439,3 +1439,76 @@ object Parser { | |||
| final case class AllBranchesFailed[Err](left: ParserError[Err], right: ParserError[Err]) extends ParserError[Err] | |||
| } | |||
| } | |||
|
|
|||
| final case class ParseFailure[+Err](input: String, error: ParserError[Err]) { | |||
There was a problem hiding this comment.
The main change, a wrapper over the input and parser error
There was a problem hiding this comment.
I would change it's name, let's say to StringParserError. That's what it really is, compared to the generic ParserError - because we know the input was a string we can provide this extra error pretty printing.
There was a problem hiding this comment.
Done, renamed the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pretty error messages indicating the position of the error in the input. Currently implemented for
parseString/parseCharsonly.