Give some love to the Validation code
#1426
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
requested review from
kyri-petrou and
a team
and removed request for
a team
- Create only 1 instance of `fail(())` - Use `NonEmptyChunk.single` in `ZValidation.fail`
guizmaii
force-pushed
the
love_validation
branch
from
155c88f
to
2602291
Compare
sideeffffect
approved these changes
Nov 26, 2024
| @@ -374,6 +374,7 @@ sealed trait ZValidation[+W, +E, +A] { self => | |||
| } | |||
|
|
|||
| object ZValidation extends LowPriorityValidationImplicits { | |||
| private val unitFailure: Validation[Unit, Nothing] = fail(()) | |||
There was a problem hiding this comment.
probably doesn't make sense to make it lazy, right?
There was a problem hiding this comment.
It doesn't indeed. It's had some synchronisation overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail(())NonEmptyChunk.singleinZValidation.fail