Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Native support #1381

Closed
wants to merge 2 commits into from
Closed

Scala Native support #1381

wants to merge 2 commits into from

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Mar 10, 2019

Initial Scala Native support for quill-core and quill-sql modules.
There is no Scalatest 3.0.x for Scala Native so I used 3.1.0-SNAP7 for Scala Native and old Scalatest for JVM and JS platforms ( default technique to port to Scala Native)

Notes

Ignored a test folder on native only because of a bug of Scala Native triggered by a test.
Did it with this sbt setting:

Test / sources :=
  (Test / sources).value
    .filterNot { s =>
      val path = s.getPath
      path.contains("src/test/scala/io/getquill/monad/")
  }

@getquill/maintainers

…nored a test folder on native only (with sbt setting)

because of a Scala Native bug.
@lolgab lolgab changed the title Scala Native support [WIP] Scala Native support Mar 10, 2019
Copy link

@ekrich ekrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lolgab Nice job.
I think it is a nice touch to add something like this towards the top of the build as it promotes DRY later in the build.

lazy val scala211 = "2.11.12"
lazy val scala212 = "2.12.8"
lazy val scala213 = "2.13.0-M5"

@lolgab lolgab changed the title [WIP] Scala Native support Scala Native support Apr 16, 2019
@deusaquilus deusaquilus mentioned this pull request May 23, 2019
5 tasks
@deusaquilus
Copy link
Collaborator

Checked out this branch and updated build in #1443.

@lolgab
Copy link
Contributor Author

lolgab commented May 23, 2019

I think we should wait to merge because they are releasing Scala Native 0.4.0-M1 and we can do a crossbuild to support both 0.4.x and 0.3.x using some environmental variable like scala-js does for cross build to 0.6 and 1.0.

@deusaquilus
Copy link
Collaborator

@lolgab It's failing on -Xms1024m. Any idea how this parameter is supposed to be specified for Scala Native?

@lolgab
Copy link
Contributor Author

lolgab commented May 23, 2019

@lolgab It's failing on -Xms1024m. Any idea how this parameter is supposed to be specified for Scala Native?

I'm not aware of any Scala Native specific problem.

@deusaquilus
Copy link
Collaborator

@lolgab That's really odd. The build fails in quill-core with the following:

[error] Expected symbol
[error] Not a valid command: -
[error] Expected end of input.
[error] Expected '--'
[error] Expected 'debug'
[error] Expected 'info'
[error] Expected 'warn'
[error] Expected 'error'
[error] Expected 'addPluginSbtFile'
[error] -Xms1024m
[error]  ^

This is the line it doesn't like:

/home/travis/.sbt/launchers/1.2.8/sbt-launch.jar
-Xms1024m     <- *** Problem happens here ***
-Xmx3g
-Xss5m
-XX:ReservedCodeCacheSize=256m
-XX:+TieredCompilation
-XX:+CMSClassUnloadingEnabled
-XX:+UseConcMarkSweepGC
++2.11.12
coverage
test

Have you ever seen this issue before?

@dwijnand
Copy link

Add -J, e.g. -J-Xms1024m.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lolgab
❌ Lorenzo Gabriele


Lorenzo Gabriele seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lolgab lolgab closed this by deleting the head repository Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants