Feat/support projectmatrix and support better crossbuilding #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThijsBroersen
force-pushed
the
feat/support-projectmatrix-and-support-better-crossbuilding
branch
from
36f8dcf
to
6f4cdd4
Compare
|
|
ThijsBroersen
commented
Nov 3, 2024
| .value, | ||
| doc / skip := BuildAssertions.requireNative(true).value, | ||
| Compile / doc / sources := BuildAssertions.requireNative(Seq.empty).value | ||
| // Test / test := { val _ = (Test / compile).value; () } // ?? |
There was a problem hiding this comment.
why was this previously set? What is the benefit?
ThijsBroersen
force-pushed
the
feat/support-projectmatrix-and-support-better-crossbuilding
branch
from
92e42b4
to
6278bc7
Compare
This was referenced Nov 16, 2024
ThijsBroersen
force-pushed
the
feat/support-projectmatrix-and-support-better-crossbuilding
branch
2 times, most recently
from
b44ab58
to
492eead
Compare
ThijsBroersen
force-pushed
the
feat/support-projectmatrix-and-support-better-crossbuilding
branch
from
492eead
to
a4c166f
Compare
ThijsBroersen
commented
Nov 16, 2024
| _.flatten | ||
| ) ++ | ||
| Seq(Lint.value) ++ | ||
| (if (ciCheckMima.value) Seq(CheckMima.value) else Seq.empty[Step.SingleStep]) |
There was a problem hiding this comment.
Perhaps it is better to have dedicated mima jobs? Per Scala version/platform?
There was a problem hiding this comment.
checkMima is now part of the lint job. Can be disabled with checkMima / skip := true
ThijsBroersen
force-pushed
the
feat/support-projectmatrix-and-support-better-crossbuilding
branch
from
f9cbda1
to
a2bad89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains quite some changes but tries to minimize the impact for the user.
After working with multiple zio-repos I noticed the build and ci setups have quite some duplication (copy paste) but also quite some differences (diverging over time). With this PR I hope the projects can scrap a lot of their own boilerplate and reuse as much as is convenient from the plugins from zio-sbt.
There are multiple projects which are building JS, JVM and Native separately in CI, this PR now does that by default by including the platforms in the ci-matrix.
The
I added two new plugins:
ZioSbtProjectPluginandZioSbtSharedZioSbtShared contains banner and tasks utils. Easy helpers to show info to the user.
ZioSbtProjectPlugin sets a default
javaPlatformto target when building artifacts by setting the-releaseflag.The plugin also adds a banner to show what java and scala versions and platforms are being used in the project.
e.g.
I have added multiple compile and test tasks:
compileJVM2_12compileJVM2_13compileJVM3compileJVMcompileJS2_12compileJS2_13compileJS3compileJScompileNative2_12compileNative2_13compileNative3compileNativecompile2_12compile2_13compile3compiletestJVM2_12testJVM2_13testJVM3testJVMtestJS2_12testJS2_13testJS3testJStestNative2_12testNative2_13testNative3testNativetest2_12test2_13test3testWhen using sbt-projectmatrix the idea is to have all in the same build scope. You will see the welcome message showing tasks for all versions and platforms available. If a compile or test task is tried for a something which is not in the current context then it will be an empty task.
ZioSbtCiPlugin I extended here and there. Based on the platforms and scala versions it will now create a matrix for the ci jobs as default behaviour.
It is now also possible to set a java distribution via
ciDefaultJavaDistribution.Check the README.md for other changes.
note: this PR also contains migrations to zio-json, as I continued on my previous PR #438