Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op): add opentelemetry to token endpoint #436

Merged
merged 2 commits into from
Sep 1, 2023
Merged

feat(op): add opentelemetry to token endpoint #436

merged 2 commits into from
Sep 1, 2023

Conversation

muhlemmer
Copy link
Collaborator

This changeadd opentelemetry to op, for the oauth/token endpoint.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #436 (ad3fc30) into main (5ade1cd) will increase coverage by 0.50%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   53.29%   53.79%   +0.50%     
==========================================
  Files          74       74              
  Lines        5727     5811      +84     
==========================================
+ Hits         3052     3126      +74     
- Misses       2415     2425      +10     
  Partials      260      260              
Files Changed Coverage Δ
pkg/op/auth_request.go 56.96% <0.00%> (-0.59%) ⬇️
pkg/op/token_jwt_profile.go 20.25% <57.14%> (+3.58%) ⬆️
pkg/op/token_request.go 61.46% <72.72%> (+0.86%) ⬆️
pkg/op/device.go 72.19% <100.00%> (+0.60%) ⬆️
pkg/op/op.go 63.45% <100.00%> (+0.29%) ⬆️
pkg/op/token.go 69.94% <100.00%> (+2.64%) ⬆️
pkg/op/token_client_credentials.go 51.19% <100.00%> (+8.93%) ⬆️
pkg/op/token_code.go 44.79% <100.00%> (+8.64%) ⬆️
pkg/op/token_exchange.go 52.11% <100.00%> (+0.82%) ⬆️
pkg/op/token_refresh.go 45.54% <100.00%> (+5.98%) ⬆️
... and 1 more

@muhlemmer muhlemmer enabled auto-merge (squash) September 1, 2023 08:40
@muhlemmer muhlemmer merged commit 1683b31 into main Sep 1, 2023
8 checks passed
@muhlemmer muhlemmer deleted the tracing branch September 1, 2023 08:53
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants