Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg/op): allow custom SupportedScopes #675

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

kevinschoonover
Copy link
Contributor

@kevinschoonover kevinschoonover commented Nov 4, 2024

Allows adding SupportedScopes to a provider configuration which affects whats displayed in the discovery endpoint

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer self-requested a review November 4, 2024 09:25
@muhlemmer muhlemmer enabled auto-merge (squash) November 12, 2024 15:04
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (0992c5f) to head (877b6a8).
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   60.06%   60.96%   +0.90%     
==========================================
  Files          80       81       +1     
  Lines        6998     7458     +460     
==========================================
+ Hits         4203     4547     +344     
- Misses       2498     2601     +103     
- Partials      297      310      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer merged commit 8afb8b8 into zitadel:main Nov 12, 2024
6 checks passed
@muhlemmer
Copy link
Collaborator

hey @kevinschoonover thanks for the contribution.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

Copy link

🎉 This PR is included in version 3.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants