Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mark pkg/strings as deprecated in favor of stdlib #680

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

isegura-eos-eng
Copy link
Contributor

This attempts to solve Issue #679.

In summary, since this project enforces +go1.21 we can deprecate the pkg/strings package which only implements a similar function from stdlib: slices.Contains.

Definition of Ready

  • [x ] I am happy with the code
  • [ x] Short description of the feature/issue is added in the pr description
  • [x ] PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (0992c5f) to head (e308fa6).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
pkg/op/auth_request.go 33.33% 2 Missing ⚠️
pkg/op/token_refresh.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   60.06%   60.97%   +0.91%     
==========================================
  Files          80       81       +1     
  Lines        6998     7459     +461     
==========================================
+ Hits         4203     4548     +345     
- Misses       2498     2601     +103     
- Partials      297      310      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the housekeeping! Just one small comment.

pkg/strings/strings.go Outdated Show resolved Hide resolved
@muhlemmer muhlemmer merged commit 6d20928 into zitadel:main Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants