Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default redirect, server redirects, nextjs 15 #255

Merged
merged 31 commits into from
Nov 25, 2024
Merged

fix: default redirect, server redirects, nextjs 15 #255

merged 31 commits into from
Nov 25, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Oct 30, 2024 •
edited
Loading

This PR implements:

  • the default redirect if no OIDC authRequestId is provided
  • improves speed of the application as redirects are moved to the serverside where possible
  • pages and features which are disabled by setting are blocked and tested to not show (loginSettings.allowRegister, allowUsernamePassword, disableLoginWithEmail, disableLoginWithPhone)

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:01pm

@peintnermax peintnermax changed the base branch from main to qa November 14, 2024 08:11
@peintnermax peintnermax changed the base branch from qa to main November 14, 2024 08:12
@vercel vercel bot requested a deployment to Preview November 22, 2024 10:41 Abandoned
@peintnermax peintnermax changed the title fix: default redirect, server redirects fix: default redirect, server redirects, nextjs 15 Nov 25, 2024
@peintnermax peintnermax marked this pull request as ready for review November 25, 2024 13:24
@peintnermax peintnermax changed the base branch from main to qa November 25, 2024 13:27
@peintnermax peintnermax merged commit 401d2a0 into qa Nov 25, 2024
7 checks passed
@peintnermax peintnermax deleted the default-redirect branch November 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peintnermax