Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add msm without serialization #4

Merged
merged 12 commits into from
Sep 11, 2024
Merged

feat: add msm without serialization #4

merged 12 commits into from
Sep 11, 2024

Conversation

diS3e
Copy link
Contributor

@diS3e diS3e commented Sep 3, 2024

Improved implementation of FFI msm, working without serialization to ByteString

@diS3e diS3e requested a review from vlasin September 3, 2024 14:10
@diS3e diS3e self-assigned this Sep 3, 2024
@vlasin vlasin requested a review from TurtlePU September 4, 2024 16:04
@vlasin
Copy link
Contributor

vlasin commented Sep 4, 2024 •
edited
Loading

  1. I propose bumping the size in the BenchProve.hs to 128 (the Haskell version will actually use FFT in that case).
  2. Update README with the info about the new benchmarks.

TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/Cargo.toml Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/fft.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/fft.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/fft.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/msm.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/msm.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/utils.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 4, 2024
View reviewed changes
rust-wrapper/src/fft.rs Outdated Show resolved Hide resolved
@TurtlePU
Copy link

TurtlePU commented Sep 4, 2024

🔥 🔥 🔥

TurtlePU
TurtlePU reviewed Sep 10, 2024
View reviewed changes
rust-wrapper/src/fft.rs Outdated Show resolved Hide resolved
TurtlePU
TurtlePU reviewed Sep 10, 2024
View reviewed changes
rust-wrapper/src/msm.rs Outdated Show resolved Hide resolved
@diS3e diS3e requested a review from TurtlePU September 10, 2024 17:16
TurtlePU
TurtlePU reviewed Sep 11, 2024
View reviewed changes
rust-wrapper/src/msm.rs Outdated Show resolved Hide resolved
@diS3e diS3e requested a review from TurtlePU September 11, 2024 08:36
@vlasin
Copy link
Contributor

vlasin commented Sep 11, 2024

Great job! 🔥

@vlasin vlasin merged commit 1f65326 into main Sep 11, 2024
@vlasin vlasin deleted the haskell-rust-ffi branch September 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurtlePU TurtlePU TurtlePU approved these changes

@vlasin vlasin vlasin approved these changes

Assignees

@diS3e diS3e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diS3e @vlasin @TurtlePU