Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the calling processes of wasm and golang consistent #25

Closed
wants to merge 6 commits into from

fix review suggests and add all txs example

8682f5b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Make the calling processes of wasm and golang consistent #25

fix review suggests and add all txs example
8682f5b
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Oct 12, 2023 in 0s

clippy

3 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 0
Note 0
Help 0

Versions

  • rustc 1.72.0 (5680fa18f 2023-08-23)
  • cargo 1.72.0 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (5680fa1 2023-08-23)

Annotations

Check failure on line 47 in interface/src/signer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mismatched types 

error[E0308]: mismatched types
  --> interface/src/signer.rs:47:27
   |
47 |         check_create2data(&self.zklink_signer, create2data.clone(), from_account)?;
   |         ----------------- ^^^^^^^^^^^^^^^^^^^ expected `Arc<ZkLinkSigner>`, found `&ZkLinkSigner`
   |         |
   |         arguments to this function are incorrect
   |
   = note: expected struct `std::sync::Arc<zklink_sdk_signers::zklink_signer::ZkLinkSigner>`
           found reference `&zklink_sdk_signers::zklink_signer::ZkLinkSigner`
note: function defined here
  --> interface/src/sign_change_pubkey.rs:66:8
   |
66 | pub fn check_create2data(
   |        ^^^^^^^^^^^^^^^^^
67 |     zklink_singer: Arc<ZkLinkSigner>,
   |     --------------------------------

Check failure on line 19 in interface/src/signer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Order` 

error: unused import: `Order`
  --> interface/src/signer.rs:19:49
   |
19 | use zklink_sdk_types::tx_type::order_matching::{Order, OrderMatching};
   |                                                 ^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

Check failure on line 3 in interface/src/signer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unresolved import `crate::sign_order::sign_order` 

error[E0432]: unresolved import `crate::sign_order::sign_order`
 --> interface/src/signer.rs:3:5
  |
3 | use crate::sign_order::sign_order;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `sign_order` in `sign_order`
  |
note: found an item that was configured out
 --> interface/src/sign_order.rs:8:8
  |
8 | pub fn sign_order(order: &Order, zklink_signer: &ZkLinkSigner) -> Result<Order, ZkSignerError> {
  |        ^^^^^^^^^^
help: consider importing this module instead
  |
3 | use crate::sign_order;
  |     ~~~~~~~~~~~~~~~~~
View more details on GitHub Actions