add wasm support for sdk #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+49
to
+64
| fn do_sign_change_pubkey_with_create2data_auth( | ||
| &self, | ||
| mut tx: ChangePubKey, | ||
| create2data: Create2Data, | ||
| ) -> Result<TxSignature, SignError> { | ||
| tx.sign(&self.zklink_signer)?; | ||
| let should_valid = tx.is_signature_valid(); | ||
| assert!(should_valid); | ||
|
|
||
| // create onchain auth data | ||
| tx.eth_auth_data = ChangePubKeyAuthData::EthCreate2 { data: create2data }; | ||
| Ok(TxSignature { | ||
| tx: tx.into(), | ||
| eth_signature: None, | ||
| }) | ||
| } |
There was a problem hiding this comment.
move do_sign_change_pubkey_with_create2data_auth to sign_transfer.rs as a function
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+121
to
+126
| #[cfg(not(feature = "ffi"))] | ||
| pub fn check_create2data( | ||
| zklink_singer: &ZkLinkSigner, | ||
| data: Create2Data, | ||
| account_address: ZkLinkAddress, | ||
| ) -> Result<(), SignError> { |
There was a problem hiding this comment.
check_create2data(
#[cfg(feature = "ffi")]
zklink_singer: Arc<ZkLinkSigner>,
#[cfg(not(feature = "ffi"))]
zklink_singer: &ZkLinkSigner,
)
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+7
to
12
|
|
||
| pub fn sign_order(order: &Order, zklink_signer: &ZkLinkSigner) -> Result<Order, ZkSignerError> { | ||
| let mut order = order.clone(); | ||
| order.signature = zklink_signer.sign_musig(&order.get_bytes())?; | ||
| Ok(order) | ||
| } |
There was a problem hiding this comment.
let mut order = Order();
sign_order(&mut order, xxx);
create_signed_order ?
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+145
to
+149
| pub fn sign_order(&self, order: &Order) -> Result<Order, SignError> { | ||
| let signed_order = sign_order(order, &self.zklink_signer)?; | ||
| Ok(signed_order) | ||
| } | ||
|
|
Fred0327
reviewed
Oct 19, 2023
Comment on lines
76
to
82
| &self, | ||
| tx: ChangePubKey, | ||
| create2data: Create2Data, | ||
| from_account: ZkLinkAddress, | ||
| ) -> Result<TxSignature, SignError> { | ||
| check_create2data(&self.zklink_signer, create2data.clone(), from_account)?; | ||
| self.do_sign_change_pubkey_with_create2data_auth(tx, create2data) |
There was a problem hiding this comment.
server already make a check for from_account
Fred0327
reviewed
Oct 19, 2023
Comment on lines
193
to
195
|
|
||
| #[cfg(not(feature = "ffi"))] | ||
| #[cfg(not(any(feature = "ffi")))] | ||
| pub fn sign_withdraw( |
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+221
to
+225
| #[cfg(not(feature = "ffi"))] | ||
| pub fn sign_order(&self, order: &Order) -> Result<Order, SignError> { | ||
| let signed_order = sign_order(order, &self.zklink_signer)?; | ||
| Ok(signed_order) | ||
| } |
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+15
to
17
| // #[cfg(feature = "web")] | ||
| pub mod json_rpc_signer; | ||
|
|
Fred0327
reviewed
Oct 19, 2023
Comment on lines
+101
to
+108
| #[cfg(feature = "web")] | ||
| pub async fn new_from_eth_json_rpc_signer(eth_signer: &JsonRpcSigner) -> Result<Self, Error> { | ||
| let signature = eth_signer | ||
| .sign_message(Self::SIGN_MESSAGE.as_bytes()) | ||
| .await?; | ||
| let seed = signature.serialize_packed(); | ||
| Self::new_from_seed(&seed) | ||
| } |
Fred0327
reviewed
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.