Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/content migration #5

Merged
merged 14 commits into from
May 16, 2024
Merged

Feat/content migration #5

merged 14 commits into from
May 16, 2024

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented May 14, 2024

What πŸ’»

  • Migrates tutorials, guides and how-tos

Why βœ‹

  • Content migration from docs

Warning

  • There are multiple internal links that have not been updated yet.

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Copy link

github-actions bot commented May 16, 2024

Visit the preview URL for this PR (updated for commit 66f5380):

https://community-cookbook-staging--pr5-feat-content-migrati-zs9pc9mu.web.app

(expires Thu, 23 May 2024 14:55:37 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@dutterbutter
Copy link
Contributor

@itsacoyote a couple UI nit picks, we can update these in subsequent PRs but want to highlight:

  • Seems the card selector border is off on out-sized cards. See image below
    Screenshot 2024-05-16 at 9 46 06β€―AM

  • I don't think we should show ALL the tutorials on the first page. Rather limit to featured posts.

  • Search bar is absent.

Let me know if you want these made into linear tickets or gh issues.

@dutterbutter
Copy link
Contributor

@itsacoyote fine to merge but please respond to the above comment.

@itsacoyote
Copy link
Contributor

@dutterbutter

  • Card mis-layout is a design issue I'm planning to fix in a separate ticket. I'll create that.
  • Displaying featured tutorials on the landing page is definitely a feature to add in. I'll set up a ticket for that as well. I don't have the flag set up yet but I do want a way to tag tutorials as "featured".
  • I disabled the search bar but can bring it back in in another ticket. There are some configuration tweaks I need to investigate with getting all the tutorial data in yml files to display properly. This would be part of having a filtering/search system.

@dutterbutter
Copy link
Contributor

πŸ‘

@itsacoyote itsacoyote merged commit dd4c8b7 into staging May 16, 2024
8 checks passed
@itsacoyote itsacoyote deleted the feat/content-migration branch May 16, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants