Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement DNS query checking upon archive get (#130) #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link

DNS Query Checking Upon Archive Get

Fixes #130

Changes

  • Add DNS refresh logic before fetching records in /api/key endpoint
  • Use existing refreshKeysFromDns function to update timestamps
  • Maintain rate limiting and error handling

Testing

  • Local tests could not be run due to missing environment configuration
  • Changes are minimal and focused on the API route logic
  • CI will run tests in the proper environment

Link to Devin run: https://app.devin.ai/sessions/04f98d4953574185823467c40a3939a0

- Add DNS refresh logic before fetching records
- Use existing refreshKeysFromDns function to update timestamps
- Maintain rate limiting and error handling

Co-Authored-By: Yush G <[email protected]>
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@Divide-By-0
Copy link
Member

Don't check all selectors under the domain, only the one that was queried If one was queried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query DNS upon archive get
1 participant