Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix self hosted issue #100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/fix self hosted issue #100

wants to merge 4 commits into from

Conversation

wshino
Copy link
Contributor

@wshino wshino commented Dec 24, 2024

Description

Currently unit tests and build format workflows have often been failed due to vm stop and vm start timing. I changed the build format is running on the runner which is provided by github. In self hosted runner, it's only for unit tests.
This workflow changes aren't working right now because this changes should be applied into main branch.

Also there is still an issue for using a spot vm, the spot vm will be terminated by gcp on its own. The workflow in github action can't retry by itself, I consider that I change the vm instance type from spot vm to the normal vm. For the current usage, I guess the cost won't reach $40 per month.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant