Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feat/169 - Testnet implemented on hardhat node #195

Closed
wants to merge 11 commits into from

Conversation

sifnoc
Copy link
Member

@sifnoc sifnoc commented Apr 8, 2021

Not fully implemented hardhat into zkopru.

  • Update docker-compose files for using hardhat node instead of ganache-cli as testnet container
  • Removed Postgres from docker and related parts

Related issue #169

@sifnoc sifnoc force-pushed the feat/169-hardhat branch 3 times, most recently from 92bc816 to 4d09a41 Compare April 19, 2021 08:41
@sifnoc
Copy link
Member Author

sifnoc commented Apr 19, 2021

docker-compose file description

  • docker-compose.dev-scratch.yml: This docker-compose file no need a source testchain for fork. the 'testnet' container will deploy Zkopru contract by self.
  • docker-compose.dev.yml: Fork a source testchain("https://zkopru-testnet.sifnoc.net") which is already deployed Zkopru contracts. The testchain mine block every 10 sec.
  • docker-compose.instant-block.yml: Fork a source testchain("https://zkopru-testnet.sifnoc.net") which is already deployed Zkopru contracts. the testchain is set automine It will mine a block if has a transaction in tx-pool.
  • docker-compose.yml: Fork a source testchain("https://zkopru-testnet.sifnoc.net") which is already deployed Zkopru contracts. Same as `docker-compose.dev.yml' but no Wallet Container.

@sifnoc sifnoc marked this pull request as ready for review April 19, 2021 13:59
@wanseob
Copy link
Member

wanseob commented Apr 20, 2021

@sifnoc Thx Jin for the hard work and your first PR to the project :) Do u have any recommended testing sequence?

@sifnoc
Copy link
Member Author

sifnoc commented Apr 20, 2021

Nothing changed existing testing, yet.

I removed contracts-for-integration-test container inside dockerfiles/docker-compose.yml because It is duplicated when run docker-compose.dev-scratch.yml

So If you asked about the 'testing sequence', I can say we should run both at least.

  • run dockerfiles/docker-compose.yml
  • run /docker-compose.dev-scratch.yml

blockGasLimit: 12000000,
forking: {
url: "https://zkopru-testnet.sifnoc.net",
blockNumber: 95 // Migration step 19 complete as 'testnet' network.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockNumber migration file description
63 18_setup deployed Zkopru Contract
64 18_setup setChallengePeriod as 30
65 18_setup register account to BurnAuction contract
93 19_migration_dest Deployed Zkopru2 contract as migration dest
94 19_migration_dest setChallengePeriod as 30
95 19_migration_dest register account to BurnAuction contract

@sifnoc
Copy link
Member Author

sifnoc commented Apr 23, 2021

Should wait for fix this issue #205 before merge this PR

@wanseob
Copy link
Member

wanseob commented Aug 11, 2021

@sifnoc would you please add [WIP] to the title or mark it as a draft?

@sifnoc sifnoc changed the title Feat/169 - Testnet implemented on hardhat node [WIP] Feat/169 - Testnet implemented on hardhat node Aug 11, 2021
@sifnoc sifnoc marked this pull request as draft August 11, 2021 14:46
@sifnoc
Copy link
Member Author

sifnoc commented Aug 21, 2021

It seems fix eth_subscribtion at https://github.com/nomiclabs/hardhat/releases/tag/hardhat-core-v2.6.1

@sifnoc
Copy link
Member Author

sifnoc commented Nov 1, 2021

This PR is going to move stress-test repo.

Create issue zkopru-network/stress-test#8 for this PR.

@sifnoc sifnoc closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants