Modified lib/game.rb #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: You should probably test this before merging. I couldn't test it. * Renamed methods * `Game#occupied_check` --> `Game#occupied?` * `Game#numeric_check` --> `Game#numeric?` * removed unneeded `[]`s
| ask_a_valid_move(player) | ||
| end | ||
| if valid_move?(move) then move | ||
| else ask_a_valid_move(player) end |
There was a problem hiding this comment.
end at 42, 36 is not aligned with if at 41, 6.
zlahham
force-pushed
the
master
branch
6 times, most recently
from
41ea9c2 to
ace2b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: You should probably test this before merging. I couldn't test it.
Game#occupied_check-->Game#occupied?Game#numeric_check-->Game#numeric?[]s