feat: lazy query A/AAAA of NSes when iterating on authorities #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Few suggestions, otherwise looks good to me.
Since we're changing the lookup behavior for all lookups, can you add a TODO to the main DNSSEC PR to do A/B tests with DNSSEC disabled to be sure our error rate/timeout rate/success rate/runtime are all similar or better with that branch than main ZDNS? Want to check for regressions.
|
Merging this now to the DNSSEC dev branch. |
|
For A/B testing, current main we have With this change (and DNSSEC on, and with Cloudflare DoH): From error rate I think we are good? Current main might get penalized for scanning too fast I assume. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.