Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ZEPHYR_SDK_VERSION from Zephyr SDK path #91

Open
wants to merge 2 commits into
base: 2.5-branch
Choose a base branch
from
Open

refactor: remove ZEPHYR_SDK_VERSION from Zephyr SDK path #91

wants to merge 2 commits into from

Conversation

innovaker
Copy link
Contributor

This provides a consistent environment between releases which is easier to script.

innovaker added 2 commits June 19, 2021 19:47
@innovaker
refactor: remove ZEPHYR_SDK_VERSION from Zephyr SDK path
9cfa898 
This provides a consistent environment between releases which is easier to script.
@innovaker
feat(dev-generic): remove ENV ZEPHYR_SDK_VERSION
1d5b180 
This is no longer required.

Reverts: edbe962.
@innovaker innovaker requested a review from petejohanson June 19, 2021 18:48
@innovaker
Copy link
Contributor Author

@petejohanson, I'm in two minds as to whether the ENV should now be removed from the dev images. I can't think of a use case where it would be needed anymore, can you? On the other hand, I guess it's pretty innocuous given it's one of the final steps/layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson Awaiting requested review from petejohanson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@innovaker