Minor fixes for behavior binding selection funkiness (#62)

* fix: Fix clearing HID usage value on binding change * Use null instead of undefined for fallback value on binding change * fix: Proper equality check on parameter value.
zmkfirmware · Oct 14, 2024 · 17208f5 · 17208f5
1 parent 096bbf0
commit 17208f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/behaviors/BehaviorBindingPicker.tsx b/src/behaviors/BehaviorBindingPicker.tsx
@@ -58,7 +58,7 @@ export const BehaviorBindingPicker = ({
     if (
       binding.behaviorId === behaviorId &&
       binding.param1 === param1 &&
-      binding.param2 == param2
+      binding.param2 === param2
     ) {
       return;
     }

diff --git a/src/behaviors/HidUsagePicker.tsx b/src/behaviors/HidUsagePicker.tsx
@@ -151,7 +151,7 @@ export const HidUsagePicker = ({
     <div className="flex gap-2 relative">
       {label && <Label id="hid-usage-picker">{label}:</Label>}
       <ComboBox
-        selectedKey={value ? mask_mods(value) : undefined}
+        selectedKey={value ? mask_mods(value) : null}
         onSelectionChange={selectionChanged}
         aria-labelledby="hid-usage-picker"
       >