fix(zoom): making zoom in+out a usable feature #116
+176
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: keyboard viewport + tools to pan-around and reset
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nicell
reviewed
Dec 22, 2024
| @@ -29,8 +29,7 @@ import { BehaviorBindingPicker } from "../behaviors/BehaviorBindingPicker"; | |||
| import { produce } from "immer"; | |||
| import { LockStateContext } from "../rpc/LockStateContext"; | |||
| import { LockState } from "@zmkfirmware/zmk-studio-ts-client/core"; | |||
| import { deserializeLayoutZoom, LayoutZoom } from "./PhysicalLayout"; | |||
| import { useLocalStorageState } from "../misc/useLocalStorageState"; | |||
There was a problem hiding this comment.
useLocalStorageState was created for future local storage uses. I don't think we should remove it #31 (comment)
There was a problem hiding this comment.
restored useLocalStorageState, i slightly modified the hook to have default serialize+deserializer, imho, these options should only be required for specific serialize+deserializer functions. lmk what you think ^^
pongstr
force-pushed
the
fix-zoom-in-out
branch
from
6140ebb to
f76a3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useLocalStorageStateto have default serializer+deserializerScreen.Recording.2024-12-22.at.20.16.13.mov