BUILD, MAINT: Migrate to Cython 3 and use the Iterator API instead of PyArray_MultiIter_* functions for iteration.
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoj613
added
maintainance
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 136 127 -9
=========================================
- Hits 136 127 -9 ☔ View full report in Codecov by Sentry. |
zoj613
changed the title
PyArray_MultiIter_* functions for iteration.
zoj613
force-pushed
the
npyiter
branch
8 times, most recently
from
3f45b32 to
502e133
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the build process from cython 0.29.* to cython 3.0.* .
It also migrates the internal broadcasting logic from numpy's old
MultiIter_*functions and uses the newer and more flexible Iterator API to encapsulate the broadcasting logic. This improves the readability and makes maintaining the code a lot easier since the numpy API does most of the allocation, broadcasting, casting and reshaping internally.The above change allows us to now accept arrays of any dimensions > 1 for the
outparameter.