Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit test for MANIFEST #1137

Closed
wants to merge 2 commits into from
Closed

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Nov 24, 2023

Purpose

Adds unit test that will capture missing updates for MANIFEST. Copied from Zonemaster-Engine.

How to test this PR

Verify that is reports when MANIFEST is not updated and not when it is.

@matsduf matsduf force-pushed the check-manifest branch 4 times, most recently from ae1b136 to cef0f49 Compare November 24, 2023 14:28
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in .travis.yml doesn't look right, but otherwise this looks good to me.

@matsduf
Copy link
Contributor Author

matsduf commented Nov 24, 2023

The changes in .travis.yml doesn't look right, but otherwise this looks good to me.

@mattias-p: No, the changes are to try to find out why the MO files are not created. I cannot see them, and the t/manifest.t cannot see them. Do you know how to do it with Travis? It works in Zonemaster-Engine, but there we run Github actions.

An alternative is make manifest, see #1136 (comment)

@matsduf matsduf marked this pull request as draft November 24, 2023 17:18
@matsduf matsduf closed this Dec 4, 2023
@matsduf matsduf deleted the check-manifest branch December 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants