Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files to manifest #1194

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Dec 4, 2024

Purpose

This PR adds missing files to manifest which were inadvertently not added by #1192.

Context

#1192

How to test this PR

Unit tests should pass, specifically t/manifest.t.

@tgreenx tgreenx added the V-Patch Versioning: The change gives an update of patch in version. label Dec 4, 2024
@tgreenx tgreenx added this to the v2024.2 milestone Dec 4, 2024
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST? Do Travis and Github actions handle this differently?

@tgreenx
Copy link
Contributor Author

tgreenx commented Dec 4, 2024

Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST? Do Travis and Github actions handle this differently?

I'm not sure. This was recently added by #1183, we'll need to discuss that again.

@tgreenx tgreenx merged commit 2f4b5b8 into zonemaster:develop Dec 4, 2024
1 check passed
@tgreenx tgreenx deleted the fix-manifest branch December 4, 2024 15:56
@matsduf
Copy link
Contributor

matsduf commented Dec 4, 2024

I'm not sure. This was recently added by #1183, we'll need to discuss that again.

We do not want to have it run when you install the dist file with cpanm.

@mattias-p
Copy link
Member

mattias-p commented Dec 4, 2024

Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST?

I did have a look just now at what Travis is doing, and yes, Travis is skipping tests that are covered by MANIFEST.SKIP. Have a look at the log from https://app.travis-ci.com/github/zonemaster/zonemaster-backend/jobs/628723592#L1285 down to line 1322. I believe this is the directory where make test is executed. AFAICT this is Travis's standard way of dealing with Perl.

Here are those lines quoted:

"/home/travis/perl5/perlbrew/perls/5.38.0/bin/perl" "-Iinc" "-MExtUtils::Manifest=mkmanifest" -e mkmanifest
rm -rf /home/travis/build/zonemaster/zonemaster-backend/build_dir
"/home/travis/perl5/perlbrew/perls/5.38.0/bin/perl" "-Iinc" "-MExtUtils::Manifest=manicopy,maniread" \
	-e "manicopy(maniread(),'/home/travis/build/zonemaster/zonemaster-backend/build_dir', 'best');"
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/nb
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/nb/LC_MESSAGES
share/locale/nb/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc/Module
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc/Module/Install
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/es
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/es/LC_MESSAGES
share/locale/es/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/patch
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/t
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend/DB
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/script
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/docs
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fr
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fr/LC_MESSAGES
share/locale/fr/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/sv
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/sv/LC_MESSAGES
share/locale/sv/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/da
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/da/LC_MESSAGES
share/locale/da/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend/Config
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fi
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fi/LC_MESSAGES
share/locale/fi/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
$ cd /home/travis/build/zonemaster/zonemaster-backend/build_dir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants