-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing files to manifest #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis did not catch that error. t/manifest.t
works on the command line. As far as I can see Travis has not run t/manifest.t
. Is that because it is in MANIFEST.SKIP and not in MANIFEST? Do Travis and Github actions handle this differently?
I'm not sure. This was recently added by #1183, we'll need to discuss that again. |
We do not want to have it run when you install the dist file with |
I did have a look just now at what Travis is doing, and yes, Travis is skipping tests that are covered by MANIFEST.SKIP. Have a look at the log from https://app.travis-ci.com/github/zonemaster/zonemaster-backend/jobs/628723592#L1285 down to line 1322. I believe this is the directory where Here are those lines quoted:
|
Purpose
This PR adds missing files to manifest which were inadvertently not added by #1192.
Context
#1192
How to test this PR
Unit tests should pass, specifically
t/manifest.t
.