Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in DNSSEC10 #1415

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix in DNSSEC10 #1415

wants to merge 1 commit into from

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Dec 11, 2024

Purpose

This PR proposes a fix in the conditional for DS10_EXPECTED_NSEC_NSEC3_MISSING in DNSSEC10, for cases when any IP protocol is unavailable (or if the IP address has already been processed).

Context

Fixes #1414

Changes

  • Use a list of queried name servers instead of all name servers

How to test this PR

Tests should pass.
Manual testing should show disabled queries for a given IP protocol and no DS10_EXPECTED_NSEC_NSEC3_MISSING message:

$ zonemaster-cli --show-testcase --level debug --no-ipv6 --test dnssec10 --raw afnic.fr | grep -Ev "EXTERNAL_QUERY|DEPENDENCY_VERSION"
   0.00 DEBUG    Unspecified    START_TIME  string=2024-12-11 13:37:10 +0100; time_t=1733920630
   0.01 DEBUG    Unspecified    TEST_TARGET  module=dnssec; testcase=dnssec10; zone=afnic.fr
   0.01 INFO     Unspecified    GLOBAL_VERSION  version=v7.0.0
   0.02 DEBUG    Unspecified    MODULE_VERSION  module=Zonemaster::Engine::Test::DNSSEC; version=v1.1.58
   0.02 DEBUG    DNSSEC10       TEST_CASE_START  testcase=DNSSEC10
  15.46 DEBUG    DNSSEC10       IPV6_DISABLED  ns=g.ext.nic.fr/2001:678:4c::1; rrtype=DNSKEY
  15.47 DEBUG    DNSSEC10       IPV6_DISABLED  ns=g.ext.nic.fr/2001:678:4c::1; rrtype=NSEC
  15.47 DEBUG    DNSSEC10       IPV6_DISABLED  ns=g.ext.nic.fr/2001:678:4c::1; rrtype=NSEC3PARAM
  15.54 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns1.nic.fr/2001:67c:2218:2::4:1; rrtype=DNSKEY
  15.54 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns1.nic.fr/2001:67c:2218:2::4:1; rrtype=NSEC
  15.54 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns1.nic.fr/2001:67c:2218:2::4:1; rrtype=NSEC3PARAM
  15.64 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns2.nic.fr/2001:660:3005:1::1:2; rrtype=DNSKEY
  15.64 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns2.nic.fr/2001:660:3005:1::1:2; rrtype=NSEC
  15.64 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns2.nic.fr/2001:660:3005:1::1:2; rrtype=NSEC3PARAM
  15.74 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns3.nic.fr/2001:660:3006:1::1:1; rrtype=DNSKEY
  15.74 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns3.nic.fr/2001:660:3006:1::1:1; rrtype=NSEC
  15.74 DEBUG    DNSSEC10       IPV6_DISABLED  ns=ns3.nic.fr/2001:660:3006:1::1:1; rrtype=NSEC3PARAM
  15.75 INFO     DNSSEC10       DS10_HAS_NSEC3  ns_list=g.ext.nic.fr/194.0.36.1;ns1.nic.fr/192.134.4.1;ns2.nic.fr/192.93.0.4;ns3.nic.fr/192.134.0.49
  15.76 DEBUG    DNSSEC10       TEST_CASE_END  testcase=DNSSEC10
  15.76 DEBUG    Unspecified    MODULE_END  module=DNSSEC

…EC10

Use a list of queried name servers instead of all name servers, in case any IP protocol is unavailable (or if the IP address has already been processed).
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. labels Dec 11, 2024
@tgreenx tgreenx added this to the v2024.2.1 milestone Dec 11, 2024
@tgreenx tgreenx linked an issue Dec 11, 2024 that may be closed by this pull request
@matsduf
Copy link
Contributor

matsduf commented Dec 11, 2024

$ zonemaster-cli --show-testcase --level info --no-ipv6 --test dnssec10 afnic.fr --raw
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v7.0.0
   8.83 INFO     DNSSEC10       DS10_HAS_NSEC3  ns_list=g.ext.nic.fr/194.0.36.1;ns1.nic.fr/192.134.4.1;ns2.nic.fr/192.93.0.4;ns3.nic.fr/192.134.0.49

I think the test should have --level debug and the output should list at least one excluded IPv6 address but no DS10_EXPECTED_NSEC_NSEC3_MISSING to be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error in DNSSEC10 when disabling either IP protocol
2 participants