Prevent ash_postgres v2.0.10 from being used #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachdaniel Sorry for bothering you, but I'm trying to fix this but it might actually be a bug in I used It only fails when loading a relationship (like diff --git a/lib/sql_implementation.ex b/lib/sql_implementation.ex
index d037d2d..7310431 100644
--- a/lib/sql_implementation.ex
+++ b/lib/sql_implementation.ex
@@ -293,6 +293,7 @@ defmodule AshPostgres.SqlImplementation do
end
end)
end
+ |> dbg
end
defp closest_fitting_type(types, values) doHere the output when running the a single test and the result of ash_postgres v2.0.9$ mix test test/ash_uuid_test.exs:75
Running ExUnit with seed: 265972, max_cases: 16
Excluding tags: [:test]
Including tags: [location: {"test/ash_uuid_test.exs", 75}]
[(ash_postgres 2.0.10) lib/sql_implementation.ex:268: AshPostgres.SqlImplementation.determine_types/2]
cond do
:erlang.function_exported(mod, :types, 0) -> mod.types()
:erlang.function_exported(mod, :args, 0) -> mod.args()
true -> [:any]
end #=> [[:any, {:array, :same}]]
|> Enum.concat(Map.keys(Ash.Query.Operator.operator_overloads(name) || %{})) #=> [[:any, {:array, :same}]]
|> Enum.map(fn types ->
case types do
:same ->
types =
for _ <- values do
:same
end
closest_fitting_type(types, values)
:any ->
for _ <- values do
:any
end
types ->
closest_fitting_type(types, values)
end
end) #=> [
[
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]},
{:in,
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]}}
]
]
|> Enum.filter(fn types -> Enum.all?(types, &(vagueness(&1) == 0)) end) #=> [
[
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]},
{:in,
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]}}
]
]
|> case do
[type] ->
if type == :any || type == {:in, :any} do
nil
else
type
end
_ ->
Enum.map(values, fn _ -> nil end)
end #=> [
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]},
{:in,
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]}}
]
.
Finished in 0.4 seconds (0.00s async, 0.4s sync)
14 tests, 0 failures, 13 excluded[
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]},
{:in,
{:parameterized, AshUUID.UUID.EctoType,
[
migration_default?: false,
prefix: "lime-smoothie",
version: 4,
encoded?: true,
prefixed?: false,
strict?: true
]}}
]ash_postgres v2.0.10mix test test/ash_uuid_test.exs:75
Running ExUnit with seed: 651359, max_cases: 16
Excluding tags: [:test]
Including tags: [location: {"test/ash_uuid_test.exs", 75}]
[(ash_postgres 2.0.9) lib/sql_implementation.ex:296: AshPostgres.SqlImplementation.determine_types/2]
cond do
:erlang.function_exported(mod, :types, 0) -> mod.types()
:erlang.function_exported(mod, :args, 0) -> mod.args()
true -> [:any]
end #=> [[:any, {:array, :same}]]
|> then(fn types ->
Enum.concat(Map.keys(Ash.Query.Operator.operator_overloads(name) || %{}), types)
end) #=> [[:any, {:array, :same}]]
|> Enum.flat_map(fn types ->
case types do
:same ->
types =
for _ <- values do
:same
end
[closest_fitting_type(types, values)]
:any ->
[]
types ->
[types]
end
end) #=> [[:any, {:array, :same}]]
|> Enum.filter(fn types -> Enum.all?(types, &(vagueness(&1) == 0)) end) #=> []
|> case do
[types] ->
types
types ->
Enum.find_value(types, Enum.map(values, fn _ -> nil end), fn types ->
if length(types) == length(values) do
types
|> Enum.zip(values)
|> Enum.reduce_while([], fn {type, value}, vals ->
type = Ash.Type.get_type(type)
if Ash.Type.ash_type?(type) do
{type, constraints} =
case type do
{type, constraints} -> {type, constraints}
type -> {type, []}
end
case value do
%Ash.Query.Function.Type{arguments: [_, ^type | _]} ->
{:cont, vals ++ [:any]}
%Ash.Query.Ref{attribute: %{type: ^type}} ->
{:cont, vals ++ [:any]}
_ ->
if Ash.Type.matches_type?(type, value, constraints) do
{:cont, vals ++ [parameterized_type(type, constraints)]}
else
{:halt, nil}
end
end
else
{:halt, nil}
end
end)
end
end)
end #=> [nil, nil]
1) test AshUUID.PrefixedV4 testing limes (AshUUIDTest)
test/ash_uuid_test.exs:75
** (Ash.Error.Unknown) Unknown Error
* ** (Postgrex.Error) ERROR 22P02 (invalid_text_representation) invalid input syntax for type uuid: "5AbK9g2dZBR6DMhp7zg7vF". If you are trying to query a JSON field, the parameter may need to be interpolated. Instead of
p.json["field"] != "value"
do
p.json["field"] != ^"value"
query: SELECT l0."id", l0."inserted_at", l0."lime_smoothie_id" FROM "limes" AS l0 WHERE (l0."lime_smoothie_id"::uuid IN ('5AbK9g2dZBR6DMhp7zg7vF'))
at limes
(ecto_sql 3.11.3) lib/ecto/adapters/sql.ex:1054: Ecto.Adapters.SQL.raise_sql_call_error/1
(ecto_sql 3.11.3) lib/ecto/adapters/sql.ex:952: Ecto.Adapters.SQL.execute/6
(ecto 3.11.2) lib/ecto/repo/queryable.ex:232: Ecto.Repo.Queryable.execute/4
(ecto 3.11.2) lib/ecto/repo/queryable.ex:19: Ecto.Repo.Queryable.all/3
(ash_postgres 2.0.10) lib/data_layer.ex:758: anonymous fn/3 in AshPostgres.DataLayer.run_query/2
(ash_postgres 2.0.10) lib/data_layer.ex:756: AshPostgres.DataLayer.run_query/2
(ash 3.0.15) lib/ash/actions/read/read.ex:2423: Ash.Actions.Read.run_query/4
(ash 3.0.15) lib/ash/actions/read/read.ex:447: anonymous fn/5 in Ash.Actions.Read.do_read/4
(ash 3.0.15) lib/ash/actions/read/read.ex:777: Ash.Actions.Read.maybe_in_transaction/3
(ash 3.0.15) lib/ash/actions/read/read.ex:248: Ash.Actions.Read.do_run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:66: anonymous fn/3 in Ash.Actions.Read.run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:65: Ash.Actions.Read.run/3
(ash 3.0.15) lib/ash/actions/read/relationships.ex:496: anonymous fn/3 in Ash.Actions.Read.Relationships.do_fetch_related_records/3
(elixir 1.17.0) lib/enum.ex:1711: anonymous fn/3 in Enum.map/2
(elixir 1.17.0) lib/enum.ex:4423: anonymous fn/3 in Enum.map/2
(elixir 1.17.0) lib/stream.ex:1879: anonymous fn/3 in Enumerable.Stream.reduce/3
(elixir 1.17.0) lib/enum.ex:4858: Enumerable.List.reduce/3
(elixir 1.17.0) lib/stream.ex:1891: Enumerable.Stream.do_each/4
(elixir 1.17.0) lib/enum.ex:4423: Enum.map/2
(ash 3.0.15) lib/ash/actions/read/relationships.ex:43: Ash.Actions.Read.Relationships.fetch_related_records/2
stacktrace:
(elixir 1.17.0) lib/process.ex:864: Process.info/2
(ash 3.0.15) lib/ash/error/unknown.ex:3: Ash.Error.Unknown."exception (overridable 2)"/1
(ash 3.0.15) /Users/hw/Projects/ash_uuid/deps/splode/lib/splode.ex:211: Ash.Error.to_class/2
(ash 3.0.15) lib/ash/error/error.ex:66: Ash.Error.to_error_class/2
(ash 3.0.15) lib/ash/actions/read/read.ex:319: anonymous fn/2 in Ash.Actions.Read.do_run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:258: Ash.Actions.Read.do_run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:66: anonymous fn/3 in Ash.Actions.Read.run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:65: Ash.Actions.Read.run/3
(ash 3.0.15) lib/ash/actions/read/relationships.ex:496: anonymous fn/3 in Ash.Actions.Read.Relationships.do_fetch_related_records/3
(elixir 1.17.0) lib/enum.ex:1711: anonymous fn/3 in Enum.map/2
(elixir 1.17.0) lib/enum.ex:4423: anonymous fn/3 in Enum.map/2
(elixir 1.17.0) lib/stream.ex:1879: anonymous fn/3 in Enumerable.Stream.reduce/3
(elixir 1.17.0) lib/enum.ex:4858: Enumerable.List.reduce/3
(elixir 1.17.0) lib/stream.ex:1891: Enumerable.Stream.do_each/4
(elixir 1.17.0) lib/enum.ex:4423: Enum.map/2
(ash 3.0.15) lib/ash/actions/read/relationships.ex:43: Ash.Actions.Read.Relationships.fetch_related_records/2
(ash 3.0.15) lib/ash/actions/read/relationships.ex:24: Ash.Actions.Read.Relationships.load/3
(ash 3.0.15) lib/ash/actions/read/read.ex:270: Ash.Actions.Read.do_run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:66: anonymous fn/3 in Ash.Actions.Read.run/3
(ash 3.0.15) lib/ash/actions/read/read.ex:65: Ash.Actions.Read.run/3
Finished in 0.3 seconds (0.00s async, 0.3s sync)
14 tests, 1 failure, 13 excluded
It looks like you were maybe right with your comment? 😆 When I remove the vagueness-filter, the function returns Any help would be appreciated! I can also report an issue in |
|
Actually, if I change the following line, the tests in diff --git a/lib/sql_implementation.ex b/lib/sql_implementation.ex
index b3242b6..08558fa 100644
--- a/lib/sql_implementation.ex
+++ b/lib/sql_implementation.ex
@@ -248,7 +248,7 @@ defmodule AshPostgres.SqlImplementation do
[]
types ->
- [types]
+ [closest_fitting_type(types, values)]
end
end)
# this doesn't seem right to me
|
|
Hi @hwuethrich I think the issue is that AshUUID.UUID should implement the new "load" callback of the Ash.Type behaviour. Thank you for notice this bug, opening the PR and your contribution! |
|
This is definitely a bug in |
|
I've just pushed a new version of |
|
Apologies for the breaking change 🙇 |
|
@zachdaniel No worries and thanks for the quick fix! @moissela Should I close this PR or would you like to merge my changes anyway? Maybe adding a dependency constraint for ash_postgres > 2.0.10? |
hwuethrich
changed the title
|
@moissela I updated the dependencies to require ash_postgres 2.0.11 or later and the tests are now passing. Not sure if the |
|
Thanks @hwuethrich and @zachdaniel, I'm merging this into main this through #11 shortly. I'm releasing to hex today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #8 I noticed that
ash_postgresv2.0.10 will break the tests and possibly other apps using this extension with the following error:This PR is just here to reproduce the errors in CI with updated dependencies.