-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages Editor: add "Choose Starting Page" dropdown #7088
Conversation
571f1af
to
de56b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I can use the dropdown to select the intended first page.
// Limited Branching Rule: | ||
// 0. a Step can only have 1 branching task (single answer question task) | ||
// 1. if a Step has a branching task, it can't have any other tasks. | ||
// 2. if a Step already has at least one task, any added question task must be a multiple answer question task. | ||
// 3. if a Step already has many tasks, any multiple answer question task can't be transformed into a single answer question task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is different than the solution described in Challenge 3.5 in the notes doc.
disallow a single-answer question task to be combined with another single-answer question task, not disallowing the possibility of combining it with all task types.
Do you plan to change enforceLimitedBranchingRule
after this PR? Before or after internal testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, the Limited Branching Rule in this PR is the old version. The new version will be implemented in a future PR, with a target to be done before internal testing starts.
619bc83
to
16b0df0
Compare
Thanks again, Delilah! |
PR Overview
Part of: Pages Editor MVP project and FEM Lab super-project
Follows #7079
Staging branch URL: https://pr-7088.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging
This PR adds the ability for project owners to set the starting page/step of a workflow, by selecting the appropriate page/step in a dropdown.
NOTE: in this PR, the term "first page/step" means the "first item in the workflow.steps data array". The term "starting page/step" means the initial page/step a volunteer sees on the FEM Classifier for this workflow. Functionally, these are the same.
New changes in this PR:
e.target.name
->e?.target?.name
) added.Screenshot: "preview link" moved to the top of the page. The "choose starting page" dropdown (seen as "Starting Page: T0") is visible next to the "Add New Task" button.
Dev Notes
❗⚠️ Due to how the FEM Classifier defines the "starting page/step/task", "choosing the starting page" may not work the way you expect, if you came from PFE.
workflow.first_task
is used to define the first Task a volunteer works on, on the PFE Classifier. (This older classifier organises by tasks, not by steps.)workflow.first_task
is ignored if a workflow has (a non-empty)workflow.steps
. This means explicitly settingworkflow.first_task = 'P3'
(step key) orworkflow.first_task = 'T3'
(task key, assuming the task is in the target page) does nothing.workflow.steps
array defines the starting page/step presented to the volunteer.Testing
Other conditions:
should just show the "Choose starting page" option.is hidden.(🤔 thought: maybe I should make this invisible then.)Status
Ready for review. 👌
Requires 7079 to be merged first before this can be merged.