Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email-related error message #7205

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix email-related error message #7205

merged 2 commits into from
Nov 19, 2024

Conversation

lcjohnso
Copy link
Member

This PR fixes the emailSettings.general.emailInvalid error message. Current message is "Verified email" in case that valid_email is False, now changes that message to "Invalid email".

cc: @Tooyosi

@coveralls
Copy link

coveralls commented Oct 24, 2024

Coverage Status

coverage: 56.705% (+0.05%) from 56.659%
when pulling e50590a on fix-email-error-msg
into 2342b1f on master.

@lcjohnso lcjohnso marked this pull request as ready for review October 24, 2024 19:31
@lcjohnso lcjohnso requested a review from mcbouslog October 24, 2024 19:32
@lcjohnso
Copy link
Member Author

Email Setting Page on Staging Branch: https://pr-7205.pfe-preview.zooniverse.org/settings/email

Using a test account and the staging branch linked above, I can confirm this PR does what it is expected to do -- see screenshots below.

Before:
Screenshot 2024-10-24 at 2 36 19 PM

After:
Screenshot 2024-10-24 at 2 35 00 PM

Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, make sense!

@goplayoutside3 goplayoutside3 merged commit 8ad3b19 into master Nov 19, 2024
5 checks passed
@goplayoutside3 goplayoutside3 deleted the fix-email-error-msg branch November 19, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants