Classifier: Remove the faulty session id code

[goplayoutside3]

Staging branch URL: https://pr-7233.pfe-preview.zooniverse.org

Paired with zooniverse/front-end-monorepo#6499

• While investigating Standardize third party libraries for generating string hash and unique ids front-end-monorepo#6493, I found that the "generate a new session id after 5 minutes of inactivity" logic does not work in the classifier. As mentioned in that Issue, session id is attached to classification metadata and can be used for analysis of anonymous users contributing classifications.
• In this PR I removed the "5 minutes" logic because its original condition of comparing a Date() string to a Date.now() number was never met, and therefore the code never worked as intended.

Required Manual Testing

• Does the projects page render correctly?
• Can you load project home pages?
• Can you load the classification page?
• Can you submit a classification?
• Does talk load correctly?
• Can you post a talk comment?

Review Checklist

• Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
• Does it work on mobile?
• Can you npm ci and app works as expected?
• If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
• Are the tests passing locally and on GitHub Actions?

[goplayoutside3]

This condition was comparing a Date() string to a Date.now() number and therefore never met. It was copied directly from PFE's codebase, so I'll be doing the same cleanup over there.

[coveralls]

coverage: 56.684% (-0.02%) from 56.705%
when pulling 17ed9d5 on remove-faulty-session-ttl
into 39a09e8 on master.

[goplayoutside3]

This feature is supposed to be a session id, which refreshes just like a browser session. If researchers are using session ids to analyze anonymous users, then don't use localStorage as a backup.

See https://github.com/zooniverse/front-end-monorepo/pull/6499/files#r1861103668

[goplayoutside3]

@shaunanoordin I'm requesting your review on this one as a pair to zooniverse/front-end-monorepo#6499. I've done my best educated guess about coffeescript, but need a second set of eyes on the changes.

[shaunanoordin]

PR Review

Related: FEM PR 6499

This PR removes some code in our session ID-generating function. The removed portion was never working, so no actual changes in website behaviour are expected.

Behaviour:

• a session ID (for a browser tab/window) is generated when any PFE page loads.
• this session ID stays for the duration of the browser session (i.e. until the tab/window closes)
• this session ID is only used when submitting classifications (i.e. on a project's Classify page). The session ID is submitted as classification.metadata.session = "some_string"

Note:

• in theory it was possible for the generated session ID to be stored/pulled from the longer-term local storage instead of short-term session storage, but in practice this should never have realistically happened. (i.e. unlikely we need to worry about a browser with no session storage, but with local storage.) Nonetheless, the removal of the "window.localStorage" fallback is desirable to keep the code intent clear: session IDs should only live in the session.

The code changes look good, and I see no particular issues with the new Coffeescript. Functionality/behaviour tests also look good.

Testing

Tested on localhost with macOS + Chrome, on an incognito window.

• Load a random PFE page, e.g. https://local.zooniverse.org:3735/projects/
• Confirm that a session ID (hexadecimal string) is generated in the session storage, in the format of session_id = '{ "id": "abcdef1234567890" }'
• Go to a random project, and go to the Classify page, e.g. https://local.zooniverse.org:3735/projects/brooke/i-fancy-cats/classify
• Submit a classification.
• Confirm that the correct session ID is submitted in the /classifications POST payload, as part of my_submitted_classification.metadata.session

Status

LGTM! 👍