Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 Deprecation - update dirty methods from enabled_change to saved_change_to_enabled #377

Merged

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Oct 22, 2024

update subscription_preference.rb and subscription.rb from enabled_change to saved_change_to_enabled on after_save callbacks. change made due to rails 5.1 changes to activemodel::dirty

see: https://docspring.com/blog/posts/rails-5-1-active-model-dirty-changes/

…_attr

change made due to rails 5.1 changes to activemodel::dirty
@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review October 22, 2024 21:39
@yuenmichelle1 yuenmichelle1 requested a review from Tooyosi October 22, 2024 21:39
@yuenmichelle1 yuenmichelle1 changed the title Rails 5.1 Deprecation - update subscription_preference.rb from enabled_change to saved_change_to_enabled Rails 5.1 Deprecation - update dirty methods from enabled_change to saved_change_to_enabled Oct 22, 2024
@yuenmichelle1 yuenmichelle1 merged commit e84061a into master Oct 29, 2024
2 checks passed
@yuenmichelle1 yuenmichelle1 deleted the rails-5.1-deprecation-subscription_preference.rb branch December 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant