-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: More ux fixups #3081
Closed
Closed
feat: More ux fixups #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH6883 review comments (#3072) Signed-off-by: alexandr cumarav <[email protected]> * feat: register gateway to additional discovery service (#3068) * chore: move babel to dev, modify webpack config, spring security Signed-off-by: achmelo <[email protected]> * fix: Integration tests for new Cloud Gateway routing (#3044) * Added routing integration tests, and some fixes Signed-off-by: Elena Kubantseva <[email protected]> * More integration tests and fixes Signed-off-by: Elena Kubantseva <[email protected]> * Addressed review comments Signed-off-by: Elena Kubantseva <[email protected]> --------- Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: achmelo <[email protected]> * chore: update dependencies (#3048) * chore: move babel to dev, modify webpack config, spring security Signed-off-by: achmelo <[email protected]> * update npm lock Signed-off-by: achmelo <[email protected]> * old component update Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: achmelo <[email protected]> * remove dependency from spring enabler (#3052) Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * [skip ci] Update version Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.10.15'. Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] Create new version: 'v2.11.0-SNAPSHOT'. Signed-off-by: achmelo <[email protected]> * [skip ci] Update version Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] [skip ci] Before tag commit 'v2.11.0'. Signed-off-by: achmelo <[email protected]> * [Gradle Release plugin] Create new version: 'v2.11.1-SNAPSHOT'. Signed-off-by: achmelo <[email protected]> * chore: Update UI per suggestions from UX + add keyboard shortcuts - Mike (#3053) * chore[ui]: Update UI per suggestions from UX (#3047) * chore[ui]: Update UI per suggestions from UX Update screens to closer align to figma. Signed-off-by: Mike Simpson <[email protected]> * style inputs and focus and hover --------- Signed-off-by: Mike Simpson <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> * wip Signed-off-by: at670475 <[email protected]> * fix zowe ui Signed-off-by: at670475 <[email protected]> * address sonar complains Signed-off-by: at670475 <[email protected]> * add tests Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * add test Signed-off-by: at670475 <[email protected]> * fix dev mode and navbar Signed-off-by: at670475 <[email protected]> --------- Signed-off-by: Mike Simpson <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: ms895784 <[email protected]> Signed-off-by: achmelo <[email protected]> * GH2883 Move ServicesInfoService to the apiml-common (#3056) Signed-off-by: alexandr cumarav <[email protected]> Co-authored-by: alexandr cumarav <[email protected]> Signed-off-by: achmelo <[email protected]> * feat: verify service SSO support from API ML (#3054) * feat(gateway): Reformatted and changed messages a little bit, also changed the container to use sets instead of a list Signed-off-by: matejpopda <[email protected]> * feat(gateway): Work on SSO verification Signed-off-by: matejpopda <[email protected]> * feat(gateway): Fixed style problems Signed-off-by: matejpopda <[email protected]> * feat(gateway): Fixed tests Signed-off-by: matejpopda <[email protected]> * feat(gateway): Coverage Signed-off-by: matejpopda <[email protected]> * feat(gateway): fixed warnings Signed-off-by: matejpopda <[email protected]> * feat(gateway): fixed integration tests Signed-off-by: matejpopda <[email protected]> * feat(gateway): small refactoring Signed-off-by: matejpopda <[email protected]> * feat(gateway): removed some files from PR Signed-off-by: matejpopda <[email protected]> * feat(gateway): addressed some comments Signed-off-by: matejpopda <[email protected]> --------- Signed-off-by: matejpopda <[email protected]> Signed-off-by: achmelo <[email protected]> * register GW into 2 DS with one being primary for auth, service info,.. Signed-off-by: achmelo <[email protected]> * wrapper for discovery clients Signed-off-by: achmelo <[email protected]> * feat: Forward client certificate from central gateway to domain gateway in request header (#3046) * Add new filter for re-sending auth source. Signed-off-by: Petr Weinfurt <[email protected]> * add license text Signed-off-by: Petr Weinfurt <[email protected]> * Read certificate from request header Signed-off-by: at670475 <[email protected]> * add integration test Signed-off-by: at670475 <[email protected]> * add header to test Signed-off-by: at670475 <[email protected]> * add unit test Signed-off-by: at670475 <[email protected]> * add error to the log Signed-off-by: at670475 <[email protected]> * optmize code and check for certificate in the attibute Signed-off-by: at670475 <[email protected]> * Add certificate signature to the additional header Signed-off-by: Petr Weinfurt <[email protected]> * Add public rest endpoint to provide JWK set. Signed-off-by: Petr Weinfurt <[email protected]> * WellKnownRestController and tests Signed-off-by: Petr Weinfurt <[email protected]> * add licenses Signed-off-by: Petr Weinfurt <[email protected]> * Add simple integration test Signed-off-by: Petr Weinfurt <[email protected]> * Add integration tests for well-known endpoint. Signed-off-by: Petr Weinfurt <[email protected]> * Add some javadoc. Signed-off-by: Petr Weinfurt <[email protected]> * Fix integration test Signed-off-by: Petr Weinfurt <[email protected]> * validate cert Signed-off-by: at670475 <[email protected]> * Simplify retrieving the public key. Signed-off-by: Petr Weinfurt <[email protected]> * Fix for integration tests Signed-off-by: Petr Weinfurt <[email protected]> * Cloud gateway provides certificate chain on public endpoint (instead of public key). Certificate is sent in Client-Cert header. Signed-off-by: Petr Weinfurt <[email protected]> * Cloud gateway implementation fixes Signed-off-by: Petr Weinfurt <[email protected]> * Categorize certs filter WIP Signed-off-by: Petr Weinfurt <[email protected]> * Merge with master branch Signed-off-by: Petr Weinfurt <[email protected]> * Fix casting exception Signed-off-by: Petr Weinfurt <[email protected]> * Cleanup. Add log messages. Signed-off-by: Petr Weinfurt <[email protected]> * Fixes Signed-off-by: Petr Weinfurt <[email protected]> * Add tests for CategorizeCertsFilter Signed-off-by: Petr Weinfurt <[email protected]> * Add CertificateValidatorTest Signed-off-by: Petr Weinfurt <[email protected]> * Add caching trusted certificates Signed-off-by: Petr Weinfurt <[email protected]> * Fix message types Signed-off-by: Petr Weinfurt <[email protected]> * Add javadoc Signed-off-by: Petr Weinfurt <[email protected]> * remove unnecessary dependency Signed-off-by: Petr Weinfurt <[email protected]> * Prepare SSL Auth for integration test. Signed-off-by: Petr Weinfurt <[email protected]> * Remove obsolete test Signed-off-by: Petr Weinfurt <[email protected]> * Add new runtime variables to start.sh files. Signed-off-by: Petr Weinfurt <[email protected]> * Add new options to manifest.yaml files Signed-off-by: Petr Weinfurt <[email protected]> * fix integration test Signed-off-by: Petr Weinfurt <[email protected]> * Update IT Signed-off-by: Petr Weinfurt <[email protected]> * Update keystore for IT Signed-off-by: Petr Weinfurt <[email protected]> * Update error messages Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Update common name in the certificate Signed-off-by: Petr Weinfurt <[email protected]> * Add tests for CategorizeCertsFilter Signed-off-by: Petr Weinfurt <[email protected]> * Add CA certificate to keystore Signed-off-by: Petr Weinfurt <[email protected]> * Add unit tests Signed-off-by: Petr Weinfurt <[email protected]> * disable forwarded cert in gateway on localhost Signed-off-by: Petr Weinfurt <[email protected]> * Resolve code review Signed-off-by: Petr Weinfurt <[email protected]> * Increase coverage Signed-off-by: Petr Weinfurt <[email protected]> * Externalize the update public keys function to the CategorizeCertsFilter. Update tests. Signed-off-by: Petr Weinfurt <[email protected]> * Increase coverage. Signed-off-by: Petr Weinfurt <[email protected]> --------- Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: at670475 <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: achmelo <[email protected]> Signed-off-by: achmelo <[email protected]> * chore: add media icon and change link color (#3057) --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * fix unregistering Signed-off-by: achmelo <[email protected]> * cleanup Signed-off-by: achmelo <[email protected]> * IT for multiple registration Signed-off-by: achmelo <[email protected]> * revert reading of DC list to original version Signed-off-by: achmelo <[email protected]> * revert checkstyle Signed-off-by: achmelo <[email protected]> * REMOVE! hardcode DS url for test Signed-off-by: achmelo <[email protected]> * run new job only Signed-off-by: achmelo <[email protected]> * skip tests Signed-off-by: achmelo <[email protected]> * styles Signed-off-by: achmelo <[email protected]> * align with original CITests Signed-off-by: achmelo <[email protected]> * add metrics service test Signed-off-by: achmelo <[email protected]> * Revert "run new job only" This reverts commit 530047e. Signed-off-by: achmelo <[email protected]> * fix: Fixes for API Catalog standalone mode (#3050) --------- Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * fix: header in api portal (#3059) Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Signed-off-by: achmelo <[email protected]> * verify registration with second DS Signed-off-by: achmelo <[email protected]> * hardcode discovery host Signed-off-by: achmelo <[email protected]> * revert local auth provider Signed-off-by: achmelo <[email protected]> * getting the list of discovery services from configuration Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * create bean conditionally Signed-off-by: achmelo <[email protected]> * changed the name from discoveryServiceUrlsList to centralRegistryUrls Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * Changed name of a variable to url Signed-off-by: sj895092 <[email protected]> Signed-off-by: achmelo <[email protected]> * enable second registration in CITests Signed-off-by: achmelo <[email protected]> * default value must be empty Signed-off-by: achmelo <[email protected]> * revert logging level Signed-off-by: achmelo <[email protected]> * fix styles Signed-off-by: achmelo <[email protected]> * code review, store unit test reports Signed-off-by: achmelo <[email protected]> * increase test coverage Signed-off-by: achmelo <[email protected]> * add licenses Signed-off-by: achmelo <[email protected]> * AOP check is done also inside getTargetObject Signed-off-by: achmelo <[email protected]> * remove empty test Signed-off-by: achmelo <[email protected]> * code review Signed-off-by: achmelo <[email protected]> * Revert "code review" This reverts commit 5cad7ed. * shutdown discoveryclient in test Signed-off-by: achmelo <[email protected]> * Revert "Revert "code review"" This reverts commit 956dbd6 Signed-off-by: achmelo <[email protected]> * skip test Signed-off-by: achmelo <[email protected]> * debug system exit Signed-off-by: achmelo <[email protected]> * return test Signed-off-by: achmelo <[email protected]> * remove debugging Signed-off-by: achmelo <[email protected]> * remove system exit Signed-off-by: achmelo <[email protected]> * separate startup check from build Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: achmelo <[email protected]> Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Mike Simpson <[email protected]> Signed-off-by: at670475 <[email protected]> Signed-off-by: alexandr cumarav <[email protected]> Signed-off-by: matejpopda <[email protected]> Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: sj895092 <[email protected]> Co-authored-by: Elena Kubantseva <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Zowe Robot <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: ms895784 <[email protected]> Co-authored-by: cumarav <[email protected]> Co-authored-by: alexandr cumarav <[email protected]> Co-authored-by: matejpopda <[email protected]> Co-authored-by: Petr Weinfurt <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: sj895092 <[email protected]> * feat: Add centralRegistryUrls config parameter to zowe.yaml (#3069) * (feat) Add centralRegistryUrls config parameter to zowe.yaml Signed-off-by: Petr Weinfurt <[email protected]> * Add cert forwarding configuration to schema Signed-off-by: Petr Weinfurt <[email protected]> * Add cert forwarding configuration to schema Signed-off-by: Petr Weinfurt <[email protected]> * add mock services to prevent shutdown of gateway Signed-off-by: achmelo <[email protected]> --------- Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: achmelo <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: achmelo <[email protected]> * chore: Update dependencies to avoid vulnerabilities V2 (#3074) Signed-off-by: Pavel Jareš <[email protected]> * chore: Add html-loader in webpack config (#3073) * Add html loader to build html files Signed-off-by: at670475 <[email protected]> * add html-loader as dev-dependency Signed-off-by: at670475 <[email protected]> * remove comment Signed-off-by: at670475 <[email protected]> * custom-logo could have double slashes Signed-off-by: Pablo Hernán Carle <[email protected]> * fix url Signed-off-by: Pablo Hernán Carle <[email protected]> --------- Signed-off-by: at670475 <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> * chore[ui]: Update UI per suggestions from UX Update screens with notes from jan/mirek Signed-off-by: Mike Simpson <[email protected]> * style fab button * rebase * flex direction column footer * unbroke the dashboard footer, now details has too many scrollbars * Supress more swagger details * Feeback in own component, hide license on details * Footer wrapping better, hide feedback button on small screens * mobile navigations * changed favicon * fix menu animation, move open/close fn * img size * wip changes for tiles? * Looks ok on small, not so good on big * flexing tiles * lint fixup * Hardcode tech docs, param for feedback * remove margin on techdoc in mobile menu * more feedback tweaks * fixed up header to be img text img * fix flex issues, mobile zowe links, footer tweaks * text align * merge * fix scroll issue * fix lint error * cleanup swagger param spacing * space between try it out button and param header, space between params, hide example * Make brett happier with fonts * Pivot from provided html for to custom react form for feedback --------- Signed-off-by: alexandr cumarav <[email protected]> Signed-off-by: achmelo <[email protected]> Signed-off-by: Elena Kubantseva <[email protected]> Signed-off-by: Pablo Hernán Carle <[email protected]> Signed-off-by: Mike Simpson <[email protected]> Signed-off-by: at670475 <[email protected]> Signed-off-by: matejpopda <[email protected]> Signed-off-by: Petr Weinfurt <[email protected]> Signed-off-by: sj895092 <[email protected]> Signed-off-by: Pavel Jareš <[email protected]> Co-authored-by: cumarav <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: Elena Kubantseva <[email protected]> Co-authored-by: Pablo Carle <[email protected]> Co-authored-by: Pablo Hernán Carle <[email protected]> Co-authored-by: Zowe Robot <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: alexandr cumarav <[email protected]> Co-authored-by: matejpopda <[email protected]> Co-authored-by: Petr Weinfurt <[email protected]> Co-authored-by: Andrea Tabone <[email protected]> Co-authored-by: sj895092 <[email protected]> Co-authored-by: achmelo <[email protected]> Co-authored-by: Pavel Jareš <[email protected]> Co-authored-by: Brian Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH6883 review comments (Update run api-layer readme #3072)
feat: register gateway to additional discovery service (feat: register gateway to additional discovery service #3068)
chore: move babel to dev, modify webpack config, spring security
fix: Integration tests for new Cloud Gateway routing (fix: Integration tests for new Cloud Gateway routing #3044)
Added routing integration tests, and some fixes
More integration tests and fixes
Addressed review comments
chore: update dependencies (chore: update dependencies #3048)
chore: move babel to dev, modify webpack config, spring security
update npm lock
old component update
remove dependency from spring enabler (fix: remove dependency from spring enabler #3052)
[skip ci] Update version
[Gradle Release plugin] [skip ci] Before tag commit 'v2.10.15'.
[Gradle Release plugin] Create new version: 'v2.11.0-SNAPSHOT'.
[skip ci] Update version
[Gradle Release plugin] [skip ci] Before tag commit 'v2.11.0'.
[Gradle Release plugin] Create new version: 'v2.11.1-SNAPSHOT'.
chore: Update UI per suggestions from UX + add keyboard shortcuts - Mike (chore: Update UI per suggestions from UX + add keyboard shortcuts - Mike #3053)
chore[ui]: Update UI per suggestions from UX (chore[ui]: Update UI per suggestions from UX #3047)
chore[ui]: Update UI per suggestions from UX
Update screens to closer align to figma.
wip
fix zowe ui
address sonar complains
add tests
add test
add test
fix dev mode and navbar
GH2883 Move ServicesInfoService to the apiml-common (ref: GH2883 Move ServicesInfoService to the apiml-common #3056)
feat: verify service SSO support from API ML (Reboot/gh647/verify sso #3054)
feat(gateway): Reformatted and changed messages a little bit, also changed the container to use sets instead of a list
feat(gateway): Work on SSO verification
feat(gateway): Fixed style problems
feat(gateway): Fixed tests
feat(gateway): Coverage
feat(gateway): fixed warnings
feat(gateway): fixed integration tests
feat(gateway): small refactoring
feat(gateway): removed some files from PR
feat(gateway): addressed some comments
register GW into 2 DS with one being primary for auth, service info,..
wrapper for discovery clients
feat: Forward client certificate from central gateway to domain gateway in request header (feat: Forward client certificate from central gateway to domain gateway in request header #3046)
Add new filter for re-sending auth source.
add license text
Read certificate from request header
add integration test
add header to test
add unit test
add error to the log
optmize code and check for certificate in the attibute
Add certificate signature to the additional header
Add public rest endpoint to provide JWK set.
WellKnownRestController and tests
add licenses
Add simple integration test
Add integration tests for well-known endpoint.
Add some javadoc.
Fix integration test
validate cert
Simplify retrieving the public key.
Fix for integration tests
Cloud gateway provides certificate chain on public endpoint (instead of public key). Certificate is sent in Client-Cert header.
Cloud gateway implementation fixes
Categorize certs filter WIP
Merge with master branch
Fix casting exception
Cleanup. Add log messages.
Fixes
Add tests for CategorizeCertsFilter
Add CertificateValidatorTest
Add caching trusted certificates
Fix message types
Add javadoc
remove unnecessary dependency
Prepare SSL Auth for integration test.
Remove obsolete test
Add new runtime variables to start.sh files.
Add new options to manifest.yaml files
fix integration test
Update IT
Update keystore for IT
Update error messages
Update common name in the certificate
Update common name in the certificate
Update common name in the certificate
Update common name in the certificate
Add tests for CategorizeCertsFilter
Add CA certificate to keystore
Add unit tests
disable forwarded cert in gateway on localhost
Resolve code review
Increase coverage
Externalize the update public keys function to the CategorizeCertsFilter. Update tests.
Increase coverage.
fix unregistering
cleanup
IT for multiple registration
revert reading of DC list to original version
revert checkstyle
REMOVE! hardcode DS url for test
run new job only
skip tests
styles
align with original CITests
add metrics service test
Revert "run new job only"
This reverts commit 530047e.
fix: header in api portal (fix: fix header in api portal #3059)
verify registration with second DS
hardcode discovery host
revert local auth provider
getting the list of discovery services from configuration
create bean conditionally
changed the name from discoveryServiceUrlsList to centralRegistryUrls
Changed name of a variable to url
enable second registration in CITests
default value must be empty
revert logging level
fix styles
code review, store unit test reports
increase test coverage
add licenses
AOP check is done also inside getTargetObject
remove empty test
code review
Revert "code review"
This reverts commit 5cad7ed.
shutdown discoveryclient in test
Revert "Revert "code review""
This reverts commit 956dbd6
skip test
debug system exit
return test
remove debugging
remove system exit
separate startup check from build
feat: Add centralRegistryUrls config parameter to zowe.yaml (feat: Add centralRegistryUrls config parameter to zowe.yaml #3069)
(feat) Add centralRegistryUrls config parameter to zowe.yaml
Add cert forwarding configuration to schema
Add cert forwarding configuration to schema
add mock services to prevent shutdown of gateway
chore: Update dependencies to avoid vulnerabilities V2 (chore: Update dependencies to avoid vulnerabilities V2 #3074)
chore: Add html-loader in webpack config (chore: Add html-loader in webpack config #3073)
Add html loader to build html files
add html-loader as dev-dependency
remove comment
custom-logo could have double slashes
fix url
chore[ui]: Update UI per suggestions from UX Update screens with notes from jan/mirek
style fab button
rebase
flex direction column footer
unbroke the dashboard footer, now details has too many scrollbars
Supress more swagger details
Feeback in own component, hide license on details
Footer wrapping better, hide feedback button on small screens
mobile navigations
changed favicon
fix menu animation, move open/close fn
img size
wip changes for tiles?
Looks ok on small, not so good on big
flexing tiles
lint fixup
Hardcode tech docs, param for feedback
remove margin on techdoc in mobile menu
more feedback tweaks
fixed up header to be img text img
fix flex issues, mobile zowe links, footer tweaks
text align
merge
fix scroll issue
fix lint error
cleanup swagger param spacing
space between try it out button and param header, space between params, hide example
Make brett happier with fonts
Pivot from provided html for to custom react form for feedback
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline