Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heap configuration from zowe.yaml #3087

Merged
merged 9 commits into from
Sep 19, 2023
Merged

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Sep 18, 2023

Description

Allow users to configure JVM heap parameters from standard zowe.yaml configuration file.

Linked to #2559
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Copy link
Member

@balhar-jakub balhar-jakub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JirkaAichler
Copy link
Contributor

Do we want to have the same heap size for all components? Wouldn't be better to have it component-specific?

@achmelo
Copy link
Member Author

achmelo commented Sep 19, 2023

Do we want to have the same heap size for all components? Wouldn't be better to have it component-specific?

It is per component, e.g. ZWE_configs_heap_max is components.gateway.heap.max in zowe.yaml for gateway, if you want to read this value in discovery you would need ZWE_components_gateway_heap_max

@JirkaAichler
Copy link
Contributor

Do we want to have the same heap size for all components? Wouldn't be better to have it component-specific?

It is per component, e.g. ZWE_configs_heap_max is components.gateway.heap.max in zowe.yaml for gateway, if you want to read this value in discovery you would need ZWE_components_gateway_heap_max

Thank you for explanation

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@achmelo achmelo merged commit 59ead89 into v2.x.x Sep 19, 2023
33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/configurable_heap branch September 19, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants