Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sonar issues #3789

Merged
merged 8 commits into from
Sep 23, 2024
Merged

chore: fix sonar issues #3789

merged 8 commits into from
Sep 23, 2024

Conversation

richard-salac
Copy link
Contributor

@richard-salac richard-salac commented Sep 20, 2024

Description

Resolve sonar issues

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKZMaDaTTh7MLIqJ&tab=code

Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Sep 20, 2024
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RK7RaDaTTh7MLItk

Signed-off-by: Richard Salac <[email protected]>
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKvGaDaTTh7MLIsc

Signed-off-by: Richard Salac <[email protected]>
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKyvaDaTTh7MLIsj

Signed-off-by: Richard Salac <[email protected]>
Signed-off-by: Richard Salac <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 20, 2024
@richard-salac richard-salac self-assigned this Sep 20, 2024
@richard-salac richard-salac force-pushed the reboot/chore/fix_sonar_v3 branch from bab797d to 5011b46 Compare September 23, 2024 15:04
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RK7RaDaTTh7MLItk

Signed-off-by: Richard Salac <[email protected]>
@richard-salac richard-salac force-pushed the reboot/chore/fix_sonar_v3 branch from 5011b46 to b3c1f4d Compare September 23, 2024 15:05
Signed-off-by: Richard Salac <[email protected]>
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@richard-salac richard-salac merged commit 98b3394 into v3.x.x Sep 23, 2024
27 of 28 checks passed
@richard-salac richard-salac deleted the reboot/chore/fix_sonar_v3 branch September 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review size/L
Projects
Development

Successfully merging this pull request may close these issues.

2 participants