Skip to content

Commit

Permalink
Disabling zosmf check box and fix minor typos
Browse files Browse the repository at this point in the history
Signed-off-by: Sergei Kurnevich <[email protected]>
  • Loading branch information
skurnevich committed Aug 20, 2024
1 parent f8fab83 commit 9c94270
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/renderer/components/stages/Planning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const Planning = () => {

const setLocValidations = (status: boolean): void => {
setLocationsValidated(status); // This sets component state and uses it for rendering.
dispatch(setIsLocationValid(status)); // This is an odd usage of redux. It sets variable to the redux state but never uses it, doesn't even have a selector, instead, it obscurely sets it to the localStorage via setPlanningStageStatus for persistance;
dispatch(setIsLocationValid(status)); // This is an odd usage of redux. It sets variable to the redux state but never uses it, doesn't even have a selector, instead, it obscurely sets it to the localStorage via setPlanningStageStatus for persistence;
}

const setValDetails = (details: any): void => { // Created a similar function for duplicated setting
Expand Down Expand Up @@ -157,7 +157,7 @@ const Planning = () => {
const validateLocations = (e: any) => {
// REVIEW: Four storages are used for these values, i've removed a pile of setters from here, but it still should be done better.
// On every form change we run formChangeHandler and setYaml to store config in the redux (1) for the UI - ok
// Also we set electron-storage (2) (window.electron.ipcRenderer.setConfigByKeyNoValidate) for persistance, which may be a bit heavy, persistance data can be saved after successful validation here in validateLocations.
// Also we set electron-storage (2) (window.electron.ipcRenderer.setConfigByKeyNoValidate) for persistence, which may be a bit heavy, persistence data can be saved after successful validation here in validateLocations.
// And as the same time here we have some metadata storage like setValDetails, which use the component state (3) setValidationDetails and the localStorage (4) setPlanningValidationDetailsState(details)

e.preventDefault();
Expand Down Expand Up @@ -480,9 +480,11 @@ Please customize the job statement below to match your system requirements.
control={
<Checkbox // TODO: Add z/OSMF off support
checked={true}
disabled={true}
title="Disabling the z/OSMF support is not implemented"
onChange={(e) => {
setShowZosmfAttributes(true);
formChangeHandler();
// setShowZosmfAttributes(true);
// formChangeHandler();
}}
/>
}
Expand Down

0 comments on commit 9c94270

Please sign in to comment.