Merge pull request #162 from zowe/fix-build

Fix build error
zowe · Jun 3, 2024 · e1b7a09 · e1b7a09
2 parents 0bf520b + f2383d5
commit e1b7a09
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 23 deletions.
diff --git a/README.md b/README.md
@@ -10,6 +10,8 @@ Node version 18.12 or higher is required.
 
 ### Developing
 
+Note: `npm run start` may succeed without errors, but `npm run make` will not. It is always advised to run `npm run make` after writing new code, or using the build automation to view errors
+
 Run `npm install` to install dependencies 
 
 Run `npm run start` to run the application locally

diff --git a/src/actions/InstallActions.ts b/src/actions/InstallActions.ts
@@ -8,7 +8,7 @@
  * Copyright Contributors to the Zowe Project.
  */
 
-import { InstallationArgs } from '../renderer/components/stages/installation/installationSlice';
+import { InstallationArgs } from '../types/stateInterfaces';
 import { IIpcConnectionArgs, IResponse } from '../types/interfaces';
 import { FTPInstallation, CLIInstallation } from './InstallationHandler';
 

diff --git a/src/actions/InstallationHandler.ts b/src/actions/InstallationHandler.ts
@@ -17,7 +17,7 @@ import { IIpcConnectionArgs, IResponse } from '../types/interfaces';
 import { ProgressStore } from "../storage/ProgressStore";
 import * as fs from 'fs';
 import { ConfigurationStore } from '../storage/ConfigurationStore';
-import { InstallationArgs } from '../renderer/components/stages/installation/installationSlice';
+import { InstallationArgs } from '../types/stateInterfaces';
 
 class Installation {
 

diff --git a/src/renderer/components/stages/installation/installationSlice.ts b/src/renderer/components/stages/installation/installationSlice.ts
@@ -13,27 +13,6 @@ import { RootState } from '../../../store';
 import { setInstallationTypeStatus, getInstallationTypeStatus, setInstallationArguments } from '../progress/StageProgressStatus'; 
 import { InstallationArgs } from '../../../../types/stateInterfaces';
 
-export interface InstallationArgs {
-  installationDir: string;
-  workspaceDir: string;
-  logDir: string,
-  extensionDir: string,
-  installationType?: string;
-  downloadDir: string;
-  userUploadedPaxPath?: string;
-  smpeDir?: string;
-  javaHome: string;
-  nodeHome: string;
-  setupConfig: any;
-  jobName: string;
-  jobPrefix: string;
-  rbacProfile: string;
-  cookieId: string;
-  zosmfHost: string,
-  zosmfPort: string,
-  zosmfApplId: string
-}
-
 interface InstallationState {
   installationArgs: InstallationArgs;
   zoweVersion: string;