Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds ZSS dataservice to the App Store #541

Open
wants to merge 3 commits into
base: new/system-app/app-store
Choose a base branch
from

Conversation

Priyansh61
Copy link

Proposed changes

The PR adds the necessary Zss Server for the app store to create a dataservice that can help install plugins on the mainframe system.

This PR addresses Issue: NA

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

@jordanfilteau1995
Copy link
Contributor

Can I get some more context? What is the App Store? Why is it controlled by a ZSS data service?

@Priyansh61
Copy link
Author

Priyansh61 commented Aug 24, 2023

Hi @jordanfilteau1995

Sorry for the lack of context in the PR details. Actually the changes are related to the App Store @sidmohanty11 and me are developing for our summer OperMainframe Mentroship Project under @DivergentEuropeans as our mentor.

The App Store is supposed to be installed on the zowe desktop responsible for installing various different plugins and components such as JES Explorer, Zlux file explorer, sample angular app , etc to ease up the user experience.

Why is it controlled by a ZSS data service?

In order to install plugins on a mainframe system we will be using SYSTEM CALL to exec the command necessary for installing the plugins. For this the "ZWE Commands" will be mainly responsible for installing / searching the required plugin.

In order to facilitate the above thing, the zss dataservice is mainly responsible.

@Priyansh61 Priyansh61 changed the title Added zssServer to the AppStore Feat : Adds zss Dataservice to the AppStore Aug 24, 2023
Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash-4.3$ ./build.sh
WARNING CCN3280 ../../c/appStoreDataService.c:87 Function argument assignment between types "char*" and "char**" is not allowed.
WARNING CCN3068 ../../c/appStoreDataService.c:119 Operation between types "char*" and "int" is not allowed.
WARNING CCN3196 ../../c/appStoreDataService.c:175 Initialization between types "struct jsonPrinter_tag*" and "int" is not allowed.
IEW2456E 9207 SYMBOL writeSuccess UNRESOLVED. MEMBER COULD NOT BE INCLUDED
FROM THE DESIGNATED CALL LIBRARY.
FSUM3065 The LINKEDIT step ended with return code 8.
Compile finished with rc=3

@DivergentEuropeans DivergentEuropeans changed the title Feat : Adds zss Dataservice to the AppStore [WIP] Adds ZSS dataservice to the App Store Aug 29, 2023
@Priyansh61 Priyansh61 force-pushed the new/system-app/zssServer branch from b8bae57 to 17cb912 Compare September 6, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants