Exclude wrong version of angular plugins by checking entrypoint content #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
There was a problem hiding this comment.
This looks alright, but may need to change from:
zowe/zlux-app-manager#614 (review)
zowe/zlux-app-server#316 (review)
| const searchParams = new URLSearchParams(window.location.search); | ||
| const useV2Desktop = searchParams.has("use-v2-desktop") && (searchParams.get("use-v2-desktop") == '1'); | ||
| let validPlugins = allPlugins.filter((plugin) => { | ||
| if (plugin.type != 'application') { |
There was a problem hiding this comment.
should be plugin?.type if parsePluginDefinitions(result) method returns an array that has undefined values
There was a problem hiding this comment.
preferably with an error log in case plugin response text could not be parsed (may be done already upstream in PluginManager)
There was a problem hiding this comment.
if you dont have a plugin type, you'll fail startup.
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Implement lookup from PR 308 of zlux-app-server
DivergentEuropeans
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to zowe/zlux-app-server#308 you can state what the location of your primary JS file is for loading.
Angular in particular uses this, and we need it to determine whether an installed plugin is appropriate for the desktop that is being loaded (which is detected by query parameters like ?use-v2-desktop=1)
This should be tested by having an angular plugin which does not use the new features of PR 308, having another which does, and testing with/without "?use-v2-desktop=1" in the URL of the desktop.
You should see that depending upon whether a plugin has or does not have v2 or v3 angular content, it will be permitted or omitted from visibility in the desktop.