Fix bug where filtering of old angular plugins occurred in wrong section #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
DivergentEuropeans
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugin-manager had code to filter plugins that wont work on the v3 desktop so that they dont show up as a choice in the v3 desktop.
unfortunately, that filter code was in the wrong place.
some code upstream in zlux-app-manager directly uses "pluginManager.pluginsById" and the filtering in loadPlugins() did not cover that.
Instead, the filtering should occur within parsePluginDefinitions() as it is used by both that function and directly sets "pluginManager.pluginsById".
In the filter now, angular plugins that are not clearly marked as v3 compatible will be excluded from "pluginManager.pluginsById", and then will not show up in the desktop as a result, as intended.