Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample scripts #341

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Sample scripts #341

merged 10 commits into from
Nov 11, 2024

Conversation

olamidepeterojo
Copy link
Contributor

@olamidepeterojo olamidepeterojo commented Oct 21, 2024

What It Does
Updated sample scripts in readme to stop using deprecated methods

Fixes #336
How to Test

Review Checklist
I certify that I have:

Additional Comments

@zFernand0 zFernand0 mentioned this pull request Oct 21, 2024
4 tasks
@zFernand0 zFernand0 linked an issue Oct 21, 2024 that may be closed by this pull request
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @olamidepeterojo,
Please add the missing signoffs

Also, there may be more places that need to be updated (aside from the example mentioned in the issue)

As another example, files.delete_data_set -> Dataset.delete 😋

@olamidepeterojo
Copy link
Contributor Author

My apologies for missing out my signoffs again...Will do accordingly

Signed-off-by: Olamide Ojo <[email protected]>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (c4e23ef) to head (3791e39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files          65       65           
  Lines        3258     3258           
=======================================
  Hits         2903     2903           
  Misses        355      355           
Flag Coverage Δ
unittests 89.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Third-Party DCO Remediation Commit for Olamide Ojo <[email protected]>

On behalf of Olamide Ojo <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 5408903

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @olamidepeterojo,
I believe that as part of this issue, we not only want to update test files... but also update the sample scripts provided to users in the various readme files.

Here is a list of what we could review for accuracy:

@t1m0thyj t1m0thyj self-requested a review November 4, 2024 16:42
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @olamidepeterojo!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
thanks for the contribution

@zFernand0 zFernand0 merged commit 4661f83 into zowe:main Nov 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Update sample scripts in readmes to remove deprecated methods Typo In README for Core Package Import
3 participants